New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DataImportCron CDI labeling #2099
Conversation
The following labels should be set by the operator that creates the resource, and not by the DataImportCron controller, otherwise it may result an unnecessary reconciliation and a race-condition. app.kubernetes.io/component app.kubernetes.io/managed-by Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/test pull-containerized-data-importer-e2e-k8s-1.21-hpp |
/cherrypick release-v1.43 |
@arnongilboa: new pull request created: #2109 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Arnon Gilboa agilboa@redhat.com
What this PR does / why we need it:
The following labels should be set by the operator that creates the resource, and not by the DataImportCron controller, otherwise it may result an unnecessary reconciliation and a race-condition.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: