Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.34] used uncached client to get cluster proxy configmap (#2055) #2122

Merged
merged 1 commit into from Jan 25, 2022
Merged

[release-v1.34] used uncached client to get cluster proxy configmap (#2055) #2122

merged 1 commit into from Jan 25, 2022

Conversation

awels
Copy link
Member

@awels awels commented Jan 21, 2022

Signed-off-by: Michael Henriksen mhenriks@redhat.com

What this PR does / why we need it:
Backport of #2055

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

BugFix: Fix unable to list ConfigMap in cluster scope error messages in cdi controller log.

@mhenriks @awels
used uncached client to get cluster proxy configmap (kubevirt#2055)
10620a6 
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jan 21, 2022
@awels
Copy link
Member Author

awels commented Jan 21, 2022

/test pull-cdi-linter

@awels
Copy link
Member Author

awels commented Jan 21, 2022

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022
@awels
Copy link
Member Author

awels commented Jan 21, 2022

/override pull-containerized-data-importer-e2e-k8s-1.19-ceph

@kubevirt-bot
Copy link
Contributor

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.19-ceph

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.19-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akalenyu
Copy link
Collaborator

are we fine with this going all the way back to 1.34?

@awels
Copy link
Member Author

awels commented Jan 24, 2022

Yes, this is causing issues all the way back to the point where the cluster wide proxy was introduced.

@awels
Copy link
Member Author

awels commented Jan 25, 2022

/hold cancel
/approve

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@mhenriks
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@kubevirt-bot kubevirt-bot merged commit d36f408 into kubevirt:release-v1.34 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke Awaiting requested review from aglitke

@maya-r maya-r Awaiting requested review from maya-r

Assignees

@mhenriks mhenriks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awels @kubevirt-bot @akalenyu @mhenriks