Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.34] Fix failing imageio test (#2148) #2154

Merged
merged 1 commit into from Feb 14, 2022

Conversation

awels
Copy link
Member

@awels awels commented Feb 10, 2022

  • Fix failing imageio test

Always enable scratch space for imageio imports.

Signed-off-by: Alexander Wels awels@redhat.com

  • Only always enable scratch space with warm migration imports.

Signed-off-by: Alexander Wels awels@redhat.com

What this PR does / why we need it:
Backport of #2148

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

* Fix failing imageio test

Always enable scratch space for imageio imports.

Signed-off-by: Alexander Wels <awels@redhat.com>

* Only always enable scratch space with warm migration imports.

Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 10, 2022
@awels
Copy link
Member Author

awels commented Feb 10, 2022

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@awels
Copy link
Member Author

awels commented Feb 10, 2022

/test pull-containerized-data-importer-e2e-k8s-1.19-ceph

@ShellyKa13
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@kubevirt-bot kubevirt-bot merged commit a9f3db6 into kubevirt:release-v1.34 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants