Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataImportCron and DataSource to openapi-spec #2189

Merged
merged 1 commit into from Mar 10, 2022

Conversation

arnongilboa
Copy link
Collaborator

Signed-off-by: Arnon Gilboa agilboa@redhat.com

What this PR does / why we need it:
Mostly for generating swagger.json consumed by kubevirt-ui

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Add DataImportCron and DataSource to openapi-spec

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 9, 2022
@mhenriks
Copy link
Member

mhenriks commented Mar 9, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@mhenriks
Copy link
Member

mhenriks commented Mar 9, 2022

/retest

1 similar comment
@yaacov
Copy link

yaacov commented Mar 10, 2022

/retest

@yaacov
Copy link

yaacov commented Mar 10, 2022

cc:// @glekner

@yaacov
Copy link

yaacov commented Mar 10, 2022

/retest

@kubevirt-bot kubevirt-bot merged commit d4fdaf3 into kubevirt:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants