Do not factor fs overhead into available space during validation

[brybacki]

What this PR does / why we need it:

This is the continuation of #2193

When validating whether an image will fit into a PV we compare the
image's virtual size to the filesystem's reported available space to
guage whether it will fit. The current calculation reduces the apparent
available space by the configured filesystem overhead value but the
overhead is already (mostly) factored into the result of Statfs. This
causes the check to fail for PVCs that are just large enough to
accommodate an image plus overhead (ie. when using the DataVolume
Storage API with filesystem PVs with capacity constrained by the PVC
storage request size).

This was not caught in testing because HPP does not have capacity
constrained PVs and we are typically testing block volumes in the ceph
lanes. It can be triggered in our CI by allocating a Filesystem PV on
ceph-rbd storage because these volumes are capacity constrained and
subject to filesystem overhead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

bz#2064936.

Special notes for your reviewer:

This is the continuation of #2193

Trying to cleanup, remove unwanted changes, verify tests.

Release note:

Do not factor fs overhead into available space during validation

[maya-r]

Inlining my rationale for closing #2194, alternate proposal to use statfs Bfree (and still account for FS overhead):

Most users who want just barely big enough DVs are using the storage API (it's mostly vm-import-operator), which already pads their size requests to be big enough.
Let's avoid trying to coordinate two different checks of FS overhead, and limit ourselves to storage profiles creating a bigger PVC to account for the FS overhead.

[brybacki]

Here message needs to be fixed:

Tests Suite: [rfe_id:138][crit:high][vendor:cnv-qe@redhat.com][level:component]Upload tests [posneg:negative][test_id:2330]Verify failure on sync upload if virtual size > pvc size fail given a large virtual size RAW XZ file expand_more
--

New test needs image in images directory.

[brybacki]

other tests still need investigation

[brybacki]

test 2329 is also about different warning/error message

[awels]

/retest

[awels]

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awels]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[awels]

/cherrypick release-v1.43
/cherrypick release-v1.38

[kubevirt-bot]

@awels: once the present PR merges, I will cherry-pick it on top of release-v1.43 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.43
/cherrypick release-v1.38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awels]

/test pull-containerized-data-importer-e2e-k8s-1.21-hpp

[kubevirt-bot]

@awels: #2195 failed to apply on top of branch "release-v1.38":

Applying: Create a test for an overhead bug
Using index info to reconstruct a base tree...
M	tests/upload_test.go
M	tests/utils/datavolume.go
M	tests/utils/upload.go
Falling back to patching base and 3-way merge...
Auto-merging tests/utils/upload.go
CONFLICT (content): Merge conflict in tests/utils/upload.go
Auto-merging tests/utils/datavolume.go
Auto-merging tests/upload_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Create a test for an overhead bug
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.43
/cherrypick release-v1.38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubevirt-bot]

@awels: new pull request created: #2198

In response to this:

/cherrypick release-v1.43
/cherrypick release-v1.38

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.