[release-v1.49] Manual fix for clone without source pvc but target pvc already populated #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shelly Kagan <skagan@redhat.com>
kubevirt-bot
added
release-note
ShellyKa13
force-pushed
the
clone-of-populated-pvc-release-v1.49
branch
from
3895f3c
to
577b6fa
Compare
In case the target pvc exists and populated we should allow the clone to complete successfully without doing anything. Adjust the code and add a test for that case. Signed-off-by: Shelly Kagan <skagan@redhat.com>
ShellyKa13
force-pushed
the
clone-of-populated-pvc-release-v1.49
branch
from
577b6fa
to
b7cf62e
Compare
brybacki
reviewed
Aug 25, 2022
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
@ShellyKa13 I think you need to coordinnate your change with @alromeros. If #2366 is merged, then your change could be smaller and simpler. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/lgtm |
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR takes part of PR: #2306
and PR: #2375
to fix this issue with minimal changes.
In case the target pvc exists and populated we should allow the clone to complete successfully without doing anything
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # BZ #2109407
https://bugzilla.redhat.com/show_bug.cgi?id=2109407
Special notes for your reviewer:
Release note: