Fix operator_test CDI CR Gets #2577
Conversation
Get rid of the assumption that CR name is cdi, so tests won't be skippd when CR name is not cdi. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
added
release-note-none
| cr := &cdis.Items[0] | ||
|
|
||
| return cr, cdiPods | ||
| Expect(cdis.Items).To(HaveLen(1)) |
There was a problem hiding this comment.
so do we prefer that test will fail because they expect to have at least 1 cdi? or should we skip if len < 1 like somewhat done before:
if len(cdis.Items) < 1 {
Skip("CDI CR does not exist. Probably managed by another operator so skipping.")
}
There was a problem hiding this comment.
why would you run CDI func tests if you have no CDI on the cluster? failing looks good to me...
There was a problem hiding this comment.
yeah it does seem weird lol I agree
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Signed-off-by: Arnon Gilboa agilboa@redhat.com
What this PR does / why we need it:
Get rid of the assumption that CR name is cdi, so tests won't be skippd when CR name is not cdi.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: