Don't use scratch space for registry node pull imports #2845
Conversation
kubevirt-bot
added
release-note
When importing via node container runtime cache, we always have the image handy locally. This manifests itself in the form of a bug where we loop over ```bash E0813 13:32:38.443088 1 data-processor.go:251] scratch space required and none found E0813 13:32:38.443102 1 importer.go:181] scratch space required and none found ``` On registry node pull imports where images are not raw Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu
force-pushed
the
fix-scratch-node-import
branch
from
1dd49ed
to
e379e4d
Compare
|
/retest |
|
/cc @awels |
| @@ -133,6 +133,13 @@ func (hs *HTTPDataSource) Info() (ProcessingPhase, error) { | |||
| if !hs.readers.Convert { | |||
| return ProcessingPhaseTransferDataFile, nil | |||
| } | |||
| if pullMethod, _ := util.ParseEnvVar(common.ImporterPullMethod, false); pullMethod == string(cdiv1.RegistryPullNode) { | |||
| hs.url, _ = url.Parse(fmt.Sprintf("nbd+unix:///?socket=%s", nbdkitSocket)) | |||
| if err = hs.n.StartNbdkit(hs.endpoint.String()); err != nil { | |||
There was a problem hiding this comment.
surprised this is working as #2832 looks like it removes nbdkit packages
There was a problem hiding this comment.
oh maybe it's just duplicate versions?
There was a problem hiding this comment.
Yeah that just removed the older version of nbdkit that was a duplicate (and actually not used in the build at all)
|
/lgtm |
|
@awels: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@awels: new pull request created: #2846 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
When importing via node container runtime, we always have the image available in the container filesystem,
so there should be no reason to use scratch space.
This manifests itself in the form of a bug where we loop over
On registry node pull imports when images are not raw. Testing for this is added in this PR
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
https://issues.redhat.com/browse/CNV-32010
Special notes for your reviewer:
Release note: