Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump containers/image so we can retry unexpected EOFs on registry pulls #2874

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

akalenyu
Copy link
Collaborator

@akalenyu akalenyu commented Aug 28, 2023

What this PR does / why we need it:
Hopefully, resuming layer pulls after "unexpected EOF" and "connection reset by peer" errors
makes us more resilient:
containers/image#1145 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Bump github.com/containers/image/v5 for resuming layer pulls after "unexpected EOF" and "connection reset by peer" errors

Hopefully the resume on EOFs gives us enough resiliency as mentioned in containers/image#1145 (comment).

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 28, 2023
@akalenyu akalenyu changed the title Bump containers/image to hopefully be more resilient to unexpected EOFs Bump containers/image so we can retry unexpected EOFs on registry pulls Aug 28, 2023
@awels
Copy link
Member

awels commented Aug 28, 2023

/test pull-containerized-data-importer-fossa

@awels
Copy link
Member

awels commented Aug 28, 2023

/lgtm
/approve
/cherrypick release-v1.57

@kubevirt-bot
Copy link
Contributor

@awels: once the present PR merges, I will cherry-pick it on top of release-v1.57 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@kubevirt-bot kubevirt-bot merged commit 973096a into kubevirt:main Aug 28, 2023
18 checks passed
@kubevirt-bot
Copy link
Contributor

@awels: #2874 failed to apply on top of branch "release-v1.57":

Applying: Bump containers/image to hopefully be more resilient to unexpected EOFs
.git/rebase-apply/patch:35733: trailing whitespace.
	
.git/rebase-apply/patch:35763: trailing whitespace.
	
.git/rebase-apply/patch:35776: trailing whitespace.
	
.git/rebase-apply/patch:43007: trailing whitespace.
This function can be called concurrently. 
.git/rebase-apply/patch:43160: trailing whitespace.
It is important to use the "Close" function when you no longer need the Reader to stop running goroutines, 
error: patch failed: vendor/github.com/klauspost/compress/README.md:9
error: vendor/github.com/klauspost/compress/README.md: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Patch failed at 0001 Bump containers/image to hopefully be more resilient to unexpected EOFs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/lgtm
/approve
/cherrypick release-v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants