Fix flakiness in waitForStorageProfileMetricInit #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/lgtm |
|
/hold |
kubevirt-bot
added
do-not-merge/hold
|
/test pull-containerized-data-importer-e2e-destructive |
If CDI CR was deleted and re-created, the metric may have old instances of the old cdi-deployment pod IP. Also added alerts Polarion test_ids and restore ginkgo output verbosity. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
alerts_test_ids
branch
from
135926a
to
bcb91cf
Compare
arnongilboa
changed the title
|
/test pull-containerized-data-importer-e2e-destructive |
|
/lgtm |
|
/test pull-containerized-data-importer-e2e-ceph-wffc |
|
/test pull-containerized-data-importer-e2e-destructive |
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
|
/test pull-containerized-data-importer-non-csi-hpp |
kubevirt-bot
removed
the
do-not-merge/hold
akalenyu
reviewed
Dec 24, 2023
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
/lgtm |
kubevirt-bot
added
lgtm
arnongilboa
added a commit
to arnongilboa/containerized-data-importer
that referenced
this pull request
Dec 25, 2023
Manual backport of kubevirt#2998 & kubevirt#3038 - CDINoDefaultStorageClass - not having a default (or virt default) SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default (or virt default) SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
added a commit
to arnongilboa/containerized-data-importer
that referenced
this pull request
Dec 25, 2023
Manual backport of kubevirt#2998 & kubevirt#3038 - CDINoDefaultStorageClass - not having a default (or virt default) SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default (or virt default) SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
…3040) Manual backport of #2998 & #3038 - CDINoDefaultStorageClass - not having a default (or virt default) SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default (or virt default) SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
added a commit
to arnongilboa/containerized-data-importer
that referenced
this pull request
Dec 26, 2023
Manual backport of kubevirt#2998 & kubevirt#3038 - CDINoDefaultStorageClass - not having a default SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
…3041) Manual backport of #2998 & #3038 - CDINoDefaultStorageClass - not having a default SC is surely not an OpenShift error, as admins may prefer their cluster users to only use explicit SC names. However, in the CDI context when DV is created with default SC but default does not exist, we will fire an error event and the PVC will be Pending for the default SC, so when there are such Pending PVCs we will fire an alert. - CDIDefaultStorageClassDegraded - when the default SC does not support CSI/Snapshot clone (smart clone) or does not have ReadWriteMany access mode (for live migration). - CDIStorageProfilesIncomplete - add storageClass and provisioner labels. - CDIDataImportCronOutdated - add dataImportCron namespace and name labels. Also: * Rename the metric kubevirt_cdi_storageprofile_status to kubevirt_cdi_storageprofile_info since it always reports value 1, where the label values provide the details about the storage class and storage profile. * Add snapshot manifests for tests and deploy snapshot CRDs in the hpp destructive lane Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
alromeros
pushed a commit
to alromeros/containerized-data-importer
that referenced
this pull request
Jan 5, 2024
* Fix flakiness in waitForStorageProfileMetricInit If CDI CR was deleted and re-created, the metric may have old instances of the old cdi-deployment pod IP. Also added alerts Polarion test_ids and restore ginkgo output verbosity. Signed-off-by: Arnon Gilboa <agilboa@redhat.com> * Fix pods_high_restart metrics to be 0 when no pods Signed-off-by: Arnon Gilboa <agilboa@redhat.com> --------- Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If CDI CR was deleted and re-created, the metric may have old instances of the old cdi-deployment pod IP.
Also added alerts Polarion test_ids and restore ginkgo output verbosity.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: