Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the JSON format of the CSV's alm-examples field #209

Merged
merged 1 commit into from Jan 16, 2022

Conversation

nunnatsa
Copy link
Contributor

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

What this PR does / why we need it:
This PR fixes the JSON format of the alm-examples annotation in the CSV.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #208

Special notes for your reviewer:

Release note:

fixes issue 208

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 16, 2022
@maya-r
Copy link
Contributor

maya-r commented Jan 16, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2022
@maya-r
Copy link
Contributor

maya-r commented Jan 16, 2022

/cherry-pick release-v0.12

@kubevirt-bot
Copy link

@maya-r: once the present PR merges, I will cherry-pick it on top of release-v0.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member

awels commented Jan 16, 2022

/lgtm
/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2022
@kubevirt-bot kubevirt-bot merged commit ceb8af0 into kubevirt:main Jan 16, 2022
@kubevirt-bot
Copy link

@maya-r: new pull request created: #210

In response to this:

/cherry-pick release-v0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa deleted the fix-208 branch January 16, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CSV's alm-examples annotation is with a wrong JSON format
4 participants