-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relationship labels to pods created by storage pool #364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good on minor question
@@ -349,7 +351,7 @@ func (r *ReconcileHostPathProvisioner) storagePoolDeploymentByNode(logger logr.L | |||
Spec: appsv1.DeploymentSpec{ | |||
Selector: &v1.LabelSelector{ | |||
MatchLabels: map[string]string{ | |||
"hpp-pool": getResourceNameWithMaxLength(sourceStoragePool.Name, "hpp", maxNameLength), | |||
"hpp-pool": resourceName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe put "hpp-pool" as a constant, we are using it in multiple places in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, done
We are only slapping the labels on the managing resource (Deployment/Job) and thus the labels are missing on the pod itself Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
ed67d02
to
ea4a9d4
Compare
/lgtm |
@awels: once the present PR merges, I will cherry-pick it on top of release-v0.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@awels: new pull request created: #365 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-v0.16 |
@awels: new pull request created: #366 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
We are only slapping the labels on the managing resource (Deployment/Job)
and thus the labels are missing on the pod itself
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2187524
Special notes for your reviewer:
Release note: