Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.12] Manual backport of #95, #100 for CI to pass #105

Merged
merged 2 commits into from Feb 3, 2022
Merged

[release-v0.12] Manual backport of #95, #100 for CI to pass #105

merged 2 commits into from Feb 3, 2022

Conversation

kubevirt-bot
Copy link

This is an automated cherry-pick of #103

/assign awels

BugFix: No feedback when HPP path is sharing host filesystem

awels and others added 2 commits February 3, 2022 14:37
@awels
Add configuration and documentation to run Open Shift certification t…
ed49b75 
…ests. (kubevirt#95)

Signed-off-by: Alexander Wels <awels@redhat.com>
@akalenyu
Check if pool paths are shared with OS (kubevirt#100)
af2c9d3 
* Add prometheus HTTP endpoint

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Check if any passed paths are shared with OS, update metric accordingly

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Unit test extracting device from findmnt .source

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Loop forever with interval over metric with a stop channel

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 3, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request Feb 3, 2022
Merged
@awels awels changed the title [release-v0.12] [release-v0.12] Manual backport of #95, #100 for CI to pass [release-v0.12] Manual backport of #95, #100 for CI to pass Feb 3, 2022
@awels
Copy link
Member

awels commented Feb 3, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2022
@kubevirt-bot
Copy link
Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022
@akalenyu akalenyu mentioned this pull request Feb 3, 2022
Closed
@kubevirt-bot kubevirt-bot merged commit b7b11f6 into kubevirt:release-v0.12 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels Awaiting requested review from awels

@maya-r maya-r Awaiting requested review from maya-r

Assignees

@awels awels

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubevirt-bot @awels @akalenyu