Skip to content

Commit

Permalink
Fix typo in DefaultCPUModel HCO API field defaulCPUModel --> defaultC…
Browse files Browse the repository at this point in the history
…PUModel Also, capitalizing CPU and VMI in the field's description. (#2024)

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
  • Loading branch information
nunnatsa committed Jul 2, 2022
1 parent 650be91 commit 10a75a0
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 23 deletions.
10 changes: 5 additions & 5 deletions deploy/crds/hco00.crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -847,12 +847,12 @@ spec:
type: object
type: array
x-kubernetes-list-type: atomic
defaulCPUModel:
defaultCPUModel:
description: 'DefaultCPUModel defines a cluster default for CPU model:
default CPU model is set when vmi doesn''t have any cpu model. When
vmi has cpu model set, then vmi''s cpu model is preferred. When
default cpu model is not set and vmi''s cpu model is not set too,
host-model will be set. Default cpu model can be changed when kubevirt
default CPU model is set when VMI doesn''t have any CPU model. When
VMI has CPU model set, then VMI''s CPU model is preferred. When
default CPU model is not set and VMI''s CPU model is not set too,
host-model will be set. Default CPU model can be changed when kubevirt
is running.'
type: string
featureGates:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -847,12 +847,12 @@ spec:
type: object
type: array
x-kubernetes-list-type: atomic
defaulCPUModel:
defaultCPUModel:
description: 'DefaultCPUModel defines a cluster default for CPU model:
default CPU model is set when vmi doesn''t have any cpu model. When
vmi has cpu model set, then vmi''s cpu model is preferred. When
default cpu model is not set and vmi''s cpu model is not set too,
host-model will be set. Default cpu model can be changed when kubevirt
default CPU model is set when VMI doesn''t have any CPU model. When
VMI has CPU model set, then VMI''s CPU model is preferred. When
default CPU model is not set and VMI''s CPU model is not set too,
host-model will be set. Default CPU model can be changed when kubevirt
is running.'
type: string
featureGates:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -847,12 +847,12 @@ spec:
type: object
type: array
x-kubernetes-list-type: atomic
defaulCPUModel:
defaultCPUModel:
description: 'DefaultCPUModel defines a cluster default for CPU model:
default CPU model is set when vmi doesn''t have any cpu model. When
vmi has cpu model set, then vmi''s cpu model is preferred. When
default cpu model is not set and vmi''s cpu model is not set too,
host-model will be set. Default cpu model can be changed when kubevirt
default CPU model is set when VMI doesn''t have any CPU model. When
VMI has CPU model set, then VMI''s CPU model is preferred. When
default CPU model is not set and VMI''s CPU model is not set too,
host-model will be set. Default CPU model can be changed when kubevirt
is running.'
type: string
featureGates:
Expand Down
2 changes: 1 addition & 1 deletion docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ HyperConvergedSpec defines the desired state of HyperConverged
| resourceRequirements | ResourceRequirements describes the resource requirements for the operand workloads. | *[OperandResourceRequirements](#operandresourcerequirements) | | false |
| scratchSpaceStorageClass | Override the storage class used for scratch space during transfer operations. The scratch space storage class is determined in the following order: value of scratchSpaceStorageClass, if that doesn't exist, use the default storage class, if there is no default storage class, use the storage class of the DataVolume, if no storage class specified, use no storage class for scratch space | *string | | false |
| vddkInitImage | VDDK Init Image eventually used to import VMs from external providers | *string | | false |
| defaulCPUModel | DefaultCPUModel defines a cluster default for CPU model: default CPU model is set when vmi doesn't have any cpu model. When vmi has cpu model set, then vmi's cpu model is preferred. When default cpu model is not set and vmi's cpu model is not set too, host-model will be set. Default cpu model can be changed when kubevirt is running. | *string | | false |
| defaultCPUModel | DefaultCPUModel defines a cluster default for CPU model: default CPU model is set when VMI doesn't have any CPU model. When VMI has CPU model set, then VMI's CPU model is preferred. When default CPU model is not set and VMI's CPU model is not set too, host-model will be set. Default CPU model can be changed when kubevirt is running. | *string | | false |
| obsoleteCPUs | ObsoleteCPUs allows avoiding scheduling of VMs for obsolete CPU models | *[HyperConvergedObsoleteCPUs](#hyperconvergedobsoletecpus) | | false |
| commonTemplatesNamespace | CommonTemplatesNamespace defines namespace in which common templates will be deployed. It overrides the default openshift namespace. | *string | | false |
| storageImport | StorageImport contains configuration for importing containerized data | *[StorageImportConfig](#storageimportconfig) | | false |
Expand Down
10 changes: 5 additions & 5 deletions pkg/apis/hco/v1beta1/hyperconverged_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ type HyperConvergedSpec struct {
// +optional
VddkInitImage *string `json:"vddkInitImage,omitempty"`

// DefaultCPUModel defines a cluster default for CPU model: default CPU model is set when vmi doesn't have any cpu model.
// When vmi has cpu model set, then vmi's cpu model is preferred.
// When default cpu model is not set and vmi's cpu model is not set too, host-model will be set.
// Default cpu model can be changed when kubevirt is running.
// DefaultCPUModel defines a cluster default for CPU model: default CPU model is set when VMI doesn't have any CPU model.
// When VMI has CPU model set, then VMI's CPU model is preferred.
// When default CPU model is not set and VMI's CPU model is not set too, host-model will be set.
// Default CPU model can be changed when kubevirt is running.
// +optional
DefaultCPUModel *string `json:"defaulCPUModel,omitempty"`
DefaultCPUModel *string `json:"defaultCPUModel,omitempty"`

// ObsoleteCPUs allows avoiding scheduling of VMs for obsolete CPU models
// +optional
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/hco/v1beta1/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 10a75a0

Please sign in to comment.