Skip to content

Commit

Permalink
Revert "[release-1.8] Enable PSA FG on Kubevirt (#2093)" (#2135)
Browse files Browse the repository at this point in the history
* Revert "Enable PSA FG on Kubevirt (#2093)"

This reverts commit 4731026.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* hack: brutal workaround to bypass SCC->PSA on OCP

brutal workaround to bypass SCC -> PSA on OCP >= 4.12

remove ASAP!!!

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
  • Loading branch information
tiraboschi committed Nov 15, 2022
1 parent 3dfd5b3 commit 66c6c46
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ var _ = Describe("HyperconvergedController", func() {
"NUMA",
"WithHostPassthroughCPU",
"VMExport",
"PSA",
}
// Get the KV
kvList := &kubevirtcorev1.KubeVirtList{}
Expand Down
4 changes: 0 additions & 4 deletions controllers/operands/kubevirt.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ const (

// Export VMs to outside of the cluster
kvVMExportGate = "VMExport"

// enable Pod Security Admission handling
kvPSA = "PSA"
)

var (
Expand All @@ -114,7 +111,6 @@ var (
kvDownwardMetricsGate,
kvNUMA,
kvVMExportGate,
kvPSA,
}

// holds a list of mandatory KubeVirt feature gates. Some of them are the hard coded feature gates and some of
Expand Down
4 changes: 4 additions & 0 deletions hack/kv-smoke-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ curl -Lo "$TESTS_BINARY" "https://storage.googleapis.com/kubevirt-prow/devel/nig
######
chmod +x "$TESTS_BINARY"

# TODO: brutal workaround to bypass SCC -> PSA on OCP >= 4.12, remove ASAP!!!
${CMD} adm policy add-scc-to-group privileged system:authenticated
######

echo "create testing infrastructure"

cat <<EOF | ${CMD} apply -f -
Expand Down
3 changes: 3 additions & 0 deletions hack/run-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ fi

if [ -n "${OPENSHIFT_BUILD_NAMESPACE:-}" ]; then
KUBECTL_BINARY="oc"
# TODO: brutal workaround to bypass SCC -> PSA on OCP >= 4.12, remove ASAP!!!
${KUBECTL_BINARY} adm policy add-scc-to-group privileged system:authenticated
######
fi

# when the tests are run in a pod, in-cluster config will be used
Expand Down

0 comments on commit 66c6c46

Please sign in to comment.