Apply unsupported feature annotations #1028

nunnatsa · 2020-12-29T21:24:55Z

HCO now support 3 new annotation on the HyperConverged CR, in jsonPatch format, in order to set/update fields in the KV, CDI or CNA CRs, that are not formally supported and are not part of the HhyperConverged API.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Release note:

HCO now support 3 new annotation on the HyperConverged CR, in jsonPatch format, in order to set/update fields in the KV, CDI or CNA CRs, that are not formally supported and are not part of the HhyperConverged API.

hco-bot · 2020-12-29T23:14:17Z

hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2020-12-29T23:14:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-azure

In response to this:

hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2020-12-30T01:28:44Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2020-12-30T01:28:50Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2020-12-30T04:40:54Z

/test hco-e2e-upgrade-prev-aws

kubevirt-bot · 2020-12-30T04:40:57Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2020-12-30T05:57:29Z

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

kubevirt-bot · 2020-12-30T05:57:34Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-01-02T13:45:35Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2021-01-02T13:45:39Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-01-02T14:43:42Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-01-02T14:43:57Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-01-03T06:59:05Z

/test hco-e2e-upgrade-prev-aws

kubevirt-bot · 2021-01-03T06:59:08Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-01-03T07:43:44Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

kubevirt-bot · 2021-01-03T07:43:50Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-01-03T08:15:10Z

/test hco-e2e-upgrade-prev-aws

kubevirt-bot · 2021-01-03T08:15:13Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-01-03T08:42:35Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-01-06T12:01:46Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-01-06T15:00:55Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2021-01-06T15:01:00Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-01-06T15:20:50Z

/test hco-e2e-upgrade-aws
/test hco-e2e-upgrade-prev-aws

kubevirt-bot · 2021-01-06T15:20:52Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-aws
/test hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-01-06T17:06:44Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-01-06T17:06:49Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zcahana

Also need to consider what's the plan for applying validation to the value of the json patches.. whether this will be included in this PR, in a different one, in the same/next release, etc...

pkg/controller/operands/operand.go

zcahana · 2021-01-07T09:23:58Z

pkg/controller/operands/operand.go

+
+func applyPatchToSpec(hc *hcov1beta1.HyperConverged, annotationName string, spec interface{}) error {
+	if cnaoUnsupportedAnnotation, ok := hc.Annotations[annotationName]; ok {
+		if err := applyAnnotationPatch(&spec, cnaoUnsupportedAnnotation); err != nil {


I get a bit confused by the exact semantics of "pointer to an interface{}"... is this assuming that all invocations pass spec by value?

I get this comment, but the alternative is to write it 3-4 times for each operand spec. So this method actually apply a json path on any object, but as the usage (now) is only for specs, I think it's ok. I can change the name to obj.

pkg/controller/operands/operand.go

pkg/controller/operands/cdi.go

zcahana · 2021-01-10T11:02:54Z

pkg/controller/operands/cdi_test.go

+				Expect(err).To(HaveOccurred())
+			})
+
+			It("Ensure func should create CDI object with changes from the annotation", func() {


What's the significant distinction between the "Ensure func...) test cases and these the directly invoke NewCDI()?
Is it worth the almost-duplicated test cases?

These are unit test. One checks the NewCDI func and one checks the ensure func. Not sure I get the comment. We need to make sure that NewCDI works and that the ensure uses it corrctlly.

pkg/controller/operands/cdi_test.go

HCO now support 3 new annotation on the HyperConverged CR, in jsonPatch format, in order to set/update fields in the KV, CDI or CNA CRs, that are not formally supported and are not part of the HhyperConverged API. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

openshift-ci · 2021-01-11T12:31:32Z

@nunnatsa: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/hco-e2e-image-index-gcp	455338ba0b53d1ccdfbb66cd4ea86673e77622a2	link	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-upgrade-prev-azure	`d89f61a`	link	`/test hco-e2e-upgrade-prev-azure`
ci/prow/hco-e2e-upgrade-azure	`d89f61a`	link	`/test hco-e2e-upgrade-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-01-11T12:50:54Z

hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

kubevirt-bot · 2021-01-11T12:51:05Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-azure, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zcahana · 2021-01-11T12:56:23Z

/lgtm
/approve

kubevirt-bot · 2021-01-11T12:56:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zcahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zcahana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zcahana · 2021-01-11T12:57:01Z

/override-bot

hco-bot · 2021-01-11T12:57:43Z

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-01-11T12:57:47Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Dec 29, 2020

nunnatsa requested review from zcahana, tiraboschi and yuvalturg December 29, 2020 21:25

kubevirt-bot requested a review from orenc1 December 29, 2020 21:25

nunnatsa force-pushed the apply-annotation branch from c2acc5e to 3996124 Compare December 29, 2020 21:32

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 1, 2021

nunnatsa force-pushed the apply-annotation branch from 3996124 to 2f603fe Compare January 2, 2021 11:45

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2021

nunnatsa force-pushed the apply-annotation branch from 922fe60 to 455338b Compare January 6, 2021 13:03

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2021

zcahana reviewed Jan 10, 2021

View reviewed changes

nunnatsa added 3 commits January 11, 2021 12:44

go fmt

526d9fa

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

rebase with the new SSP changes

1da60a2

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

nunnatsa force-pushed the apply-annotation branch from 455338b to 49d1c19 Compare January 11, 2021 10:44

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2021

Fix code review comments

d89f61a

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

nunnatsa force-pushed the apply-annotation branch from 49d1c19 to d89f61a Compare January 11, 2021 10:54

kubevirt-bot assigned zcahana Jan 11, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021

kubevirt-bot merged commit 47a4141 into kubevirt:master Jan 11, 2021

nunnatsa deleted the apply-annotation branch January 11, 2021 14:08

Apply unsupported feature annotations #1028

Apply unsupported feature annotations #1028

Conversation

nunnatsa commented Dec 29, 2020

hco-bot commented Dec 29, 2020

kubevirt-bot commented Dec 29, 2020

hco-bot commented Dec 30, 2020

kubevirt-bot commented Dec 30, 2020

nunnatsa commented Dec 30, 2020

kubevirt-bot commented Dec 30, 2020

hco-bot commented Dec 30, 2020

kubevirt-bot commented Dec 30, 2020

hco-bot commented Jan 2, 2021

kubevirt-bot commented Jan 2, 2021

hco-bot commented Jan 2, 2021

kubevirt-bot commented Jan 2, 2021

nunnatsa commented Jan 3, 2021

kubevirt-bot commented Jan 3, 2021

hco-bot commented Jan 3, 2021

kubevirt-bot commented Jan 3, 2021

nunnatsa commented Jan 3, 2021

kubevirt-bot commented Jan 3, 2021

hco-bot commented Jan 3, 2021

kubevirt-bot commented Jan 6, 2021

hco-bot commented Jan 6, 2021

kubevirt-bot commented Jan 6, 2021

nunnatsa commented Jan 6, 2021

kubevirt-bot commented Jan 6, 2021

hco-bot commented Jan 6, 2021

kubevirt-bot commented Jan 6, 2021

zcahana left a comment

Choose a reason for hiding this comment

zcahana Jan 7, 2021

Choose a reason for hiding this comment

nunnatsa Jan 11, 2021

Choose a reason for hiding this comment

zcahana Jan 10, 2021

Choose a reason for hiding this comment

nunnatsa Jan 11, 2021

Choose a reason for hiding this comment

openshift-ci bot commented Jan 11, 2021 • edited

hco-bot commented Jan 11, 2021

kubevirt-bot commented Jan 11, 2021

zcahana commented Jan 11, 2021

kubevirt-bot commented Jan 11, 2021

zcahana commented Jan 11, 2021

hco-bot commented Jan 11, 2021

kubevirt-bot commented Jan 11, 2021

openshift-ci bot commented Jan 11, 2021 •

edited