Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KubeVirt Images From quay.io #1066

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

nunnatsa
Copy link
Collaborator

KubeVirt move to store images in quay.io in v0.36.0 and in v0.37.0 KubeVirt quit using docker.io

This PR is a preperation for this mandatory change in v0.37.0, while it's still optional (in v0.36.0), by using the images from quay.io and allow automatic version bump of KubeVirt, that is actually blocked before this change.

This PR also fixes two automation issues:

  • In release-bumber.sh, added SSP to the KubeVirt ignored packages from kubevirt.io, to avoid wrong change in SSP version when KubeVirt version is changed.
  • In tools/digester fix an issue that when creating the deploy/images.env file, the long line of the DIGEST_LIST variable breaks sometimes. Now each image is accumulated in a seperate line into the DIGEST_LIST variable.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Release note:

Use KubeVirt images from quay.io instead of dockr.io

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 18, 2021
@nunnatsa nunnatsa requested a review from orenc1 January 18, 2021 14:54
@orenc1
Copy link
Collaborator

orenc1 commented Jan 18, 2021

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@hco-bot
Copy link
Collaborator

hco-bot commented Jan 18, 2021

hco-e2e-image-index-aws, hco-e2e-image-index-azure lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws, hco-e2e-image-index-azure lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator

orenc1 commented Jan 18, 2021

/retest

@nunnatsa
Copy link
Collaborator Author

/rebase

nunnatsa and others added 2 commits January 18, 2021 22:05
KubeVirt move to store images in quay.io in v0.36.0 and in v0.37.0 KubeVirt quit using docker.io

This PR is a preperation for this mandatory change in v0.37.0, while it's still optional (in v0.36.0)

This PR also fixes two automation issues:
* In `release-bumber.sh`, added SSP to the KubeVirt ignored packages from kubevirt.io, to avoid wrong change in SSP version when KubeVirt version is changed.
* In `tools/digester` fix an issue that when creating the deploy/images.env file, the long line of the `DIGEST_LIST` variable breaks sometimes. Now each image is accumulated in a seperate line into the `DIGEST_LIST` variable.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna Tsameret (Rebase PR Action) <nunnatsa@users.noreply.github.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@hco-bot
Copy link
Collaborator

hco-bot commented Jan 19, 2021

hco-e2e-upgrade-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-aws
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-aws, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-aws
hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2021

@nunnatsa: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-upgrade-prev-azure 9b8022b link /test hco-e2e-upgrade-prev-azure
ci/prow/hco-e2e-upgrade-aws 9b8022b link /test hco-e2e-upgrade-aws
ci/prow/hco-e2e-image-index-gcp 9b8022b link /test hco-e2e-image-index-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Jan 19, 2021

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator

orenc1 commented Jan 19, 2021

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
@kubevirt-bot kubevirt-bot merged commit 87c0ac5 into kubevirt:master Jan 19, 2021
@nunnatsa nunnatsa deleted the kv-move-to-quay branch January 19, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants