[WIP] Add func-tests into operator image #1072
Conversation
Signed-off-by: Erkan Erol <eerol@redhat.com>
kubevirt-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Makefile
Outdated
| @@ -25,7 +25,7 @@ sanity: | |||
| ./hack/build-manifests.sh | |||
| git difftool -y --trust-exit-code --extcmd=./hack/diff-csv.sh | |||
|
|
|||
| build: build-operator build-csv-merger build-webhook | |||
| build: build-operator build-csv-merger build-webhook build-functest | |||
There was a problem hiding this comment.
Please remove build-webhook. Not in use here.
There was a problem hiding this comment.
Since we call make build in sanity checks as well, I reverted this part and call the targets in Dockerfile selectively.
|
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Erkan Erol <eerol@redhat.com>
|
Question: Why don't we vendor files for func-tests? While adding the test binary into the operator image, should not we vendor dependencies of tests as well? @tiraboschi @nunnatsa |
|
@erkanerol: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@erkanerol: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We decided to discuss this approach again and to find another way. Closing... |
Signed-off-by: Erkan Erol eerol@redhat.com
Release note: