Fix a bug where HCO is ready while there is handling one of the operand returns error #1097
Conversation
…nd returns error HCO should not be ready (return a positive response in the readiness prob), if it failes to handle one of the operands. But instead, HCO is ready in such case. This PR is fixing this problem by setting the ready state to false in case of operator handling error. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
kubevirt-bot
added
release-note-none
nunnatsa
changed the title
kubevirt-bot
added
release-note
|
SonarCloud Quality Gate failed.
|
Pull Request Test Coverage Report for Build 512590434
💛 - Coveralls |
|
@nunnatsa: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override-bot |
|
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-1.3 |
|
@nunnatsa: new pull request created: #1098 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
HCO should not be ready (return a positive response in the readiness prob), if it failes to handle one of the operands. But instead, HCO is ready in such case.
This PR is fixing this problem by setting the ready state to false in case of operator handling error.
Fixes: https://bugzilla.redhat.com/1920576
Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com
Release note: