Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMO was using wrong api group #147

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

rthallisey
Copy link

kubevirt-hyperconverged also shouldn't have a comma.

@rthallisey
Copy link
Author

ci test please

@yanirq
Copy link
Contributor

yanirq commented Jun 30, 2019

lgtm
@rthallisey will this handle the alm-example to be shown properly as well ?

@rthallisey
Copy link
Author

@yanirq yes. Looks like OLM noticed NMO was using the wrong API group so it ignored the spec changes.

@rthallisey rthallisey merged commit d379831 into kubevirt:master Jul 1, 2019
@rthallisey rthallisey deleted the fix-nmo-template branch July 1, 2019 10:38
rthallisey pushed a commit to rthallisey/hyperconverged-cluster-operator that referenced this pull request Jul 1, 2019
tiraboschi pushed a commit that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants