Fix template files. #154
Merged
Fix template files. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the macro processing issue, an empty line was inserted as the very first line of CRB files. This was causing issues with tools that use strict checking of the YAML file syntax. Specifically it was causing the build using the latest origin-operator-registry image to fail. This patch fixes the templates. Signed-off-by: Lev Veyde <lveyde@redhat.com>
djzager
suggested changes
Jul 3, 2019
|
OK, replaced by another set of patches. Please see PR#155. |
We no longer need the CRB files of the CDI and CNA. This patch removes the templates for both. Signed-off-by: Lev Veyde <lveyde@redhat.com> Conflicts: templates/olm-catalog/kubevirt-hyperconverged/VERSION/cdi-operator.crb.yaml.in templates/olm-catalog/kubevirt-hyperconverged/VERSION/cna-operator.crb.yaml.in
We no longer need the CRB files of the CDI and CNA. This patch removes the manifests for both. Signed-off-by: Lev Veyde <lveyde@redhat.com>
|
Per request added re-based set of patches to this PR as well. |
rthallisey
approved these changes
Jul 3, 2019
|
ci test please |
|
Which PR is winning here, this or #155 ? |
|
I think #155 can be closed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the macro processing issue, an empty line was inserted as the very first line of CRB files.
This was causing issues with tools that use strict checking of the YAML file syntax.
Specifically it was causing the build using the latest origin-operator-registry image to fail.
This patch fixes the templates.
Signed-off-by: Lev Veyde lveyde@redhat.com