Provide virtio-win pullspec in dedicated ConfigMap #1647

orenc1 · 2021-12-05T22:33:56Z

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2025295

When creating a VirtualMachine with OpenShift UI wizard, the UI searches for a ConfigMap that contains the pullspec for virtio-win image. The problem was that the ConfigMap was not accessible by non-admin users.
In previous releases, this data was overloaded onto v2v-vmware ConfigMap, which was detached from HCO in current version, along with VM Import Operator (has been separated into independent operator - MTV / Konveyor).

This PR adds a new ConfigMap, named virtio-win into HCO reconciliation loop, along with corresponding Role and RoleBinding for every authenticated user.

This PR is coupled with another PR against openshift/console, for updating the ConfigMap resolution:
openshift/console#10616

Signed-off-by: orenc1 ocohen@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Add virtio-win ConfigMap [BugFix for #2025295]

hco-bot · 2021-12-06T00:33:07Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2021-12-06T00:33:12Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-06T02:21:36Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-06T02:21:38Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-06T13:12:17Z

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-06T13:12:20Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-06T13:35:57Z

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-12-06T13:36:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws, ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/hco-e2e-upgrade-prev-index-aws, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-06T14:43:24Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-06T14:43:27Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2021-12-06T15:58:46Z

Pull Request Test Coverage Report for Build 1569610715

201 of 225 (89.33%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 70.491%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/operands/cmHandler.go	36	46	78.26%
pkg/controller/operands/rbac.go	77	91	84.62%

Totals
Change from base Build 1566848339:	0.5%
Covered Lines:	3674
Relevant Lines:	5212

💛 - Coveralls

hco-bot · 2021-12-06T17:15:08Z

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2021-12-06T17:15:11Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-06T17:27:57Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-image-index-aws, hco-e2e-image-index-azure lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-06T17:28:05Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws
hco-e2e-image-index-aws, hco-e2e-image-index-azure lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-12T13:23:57Z

pkg/controller/operands/cdi_test.go

+				handler, _ := newConfigReaderRoleBindingHandler(logger, cl, commonTestUtils.GetScheme(), hco)
+				res := handler[0].ensure(req)


nunnatsa · 2021-12-12T13:24:08Z

pkg/controller/operands/cdi_test.go

+				handler, _ := newConfigReaderRoleBindingHandler(logger, cl, commonTestUtils.GetScheme(), hco)
+				res := handler[0].ensure(req)


Signed-off-by: orenc1 <ocohen@redhat.com>

sonarcloud · 2021-12-12T13:46:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

nunnatsa · 2021-12-12T15:02:09Z

/lgtm
/approve

kubevirt-bot · 2021-12-12T15:02:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hco-bot · 2021-12-12T15:09:02Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-12T15:09:04Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-12T15:30:07Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2021-12-12T15:30:10Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-12T16:50:47Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-12T16:50:49Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-12T17:15:06Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2021-12-12T17:15:09Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 · 2021-12-12T17:20:21Z

SNO lanes failed on timeout while deleting the kubevirt-hyperconverged namespace.

/retest

nunnatsa · 2021-12-12T19:59:35Z

/test ci/prow/hco-e2e-upgrade-index-sno-azure
/test ci/prow/hco-e2e-upgrade-index-sno-aws

openshift-ci · 2021-12-12T19:59:36Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test ci-index
/test ci-index-hco-upgrade-bundle
/test ci-index-hco-upgrade-prev-bundle
/test hco-e2e-image-index-aws
/test hco-e2e-image-index-azure
/test hco-e2e-image-index-gcp
/test hco-e2e-kv-smoke-azure
/test hco-e2e-kv-smoke-gcp
/test hco-e2e-upgrade-index-aws
/test hco-e2e-upgrade-index-azure
/test hco-e2e-upgrade-prev-index-aws
/test hco-e2e-upgrade-prev-index-azure
/test images
/test okd-ci-index
/test okd-ci-index-hco-upgrade-bundle
/test okd-ci-index-hco-upgrade-prev-bundle
/test okd-hco-e2e-image-index-aws
/test okd-hco-e2e-image-index-gcp
/test okd-hco-e2e-upgrade-index-aws
/test okd-hco-e2e-upgrade-index-gcp
/test okd-images

The following commands are available to trigger optional jobs:

/test hco-e2e-image-index-sno-aws
/test hco-e2e-image-index-sno-azure
/test hco-e2e-upgrade-index-sno-aws
/test hco-e2e-upgrade-index-sno-azure
/test hco-e2e-upgrade-prev-index-sno-aws
/test hco-e2e-upgrade-prev-index-sno-azure

Use /test all to run all jobs.

In response to this:

/test ci/prow/hco-e2e-upgrade-index-sno-azure
/test ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2021-12-12T19:59:37Z

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.21

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/test ci/prow/hco-e2e-upgrade-index-sno-azure
/test ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-12-12T20:49:35Z

/retest

nunnatsa · 2021-12-13T05:09:45Z

/retest

orenc1 · 2021-12-13T08:28:05Z

/retest

openshift-ci · 2021-12-13T08:41:25Z

@orenc1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-gcp	`f09bb23`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/okd-hco-e2e-upgrade-index-gcp	`f09bb23`	link	true	`/test okd-hco-e2e-upgrade-index-gcp`
ci/prow/hco-e2e-upgrade-index-azure	`f09bb23`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-kv-smoke-gcp	`f09bb23`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/hco-e2e-image-index-sno-aws	`f09bb23`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-upgrade-index-sno-azure	`f09bb23`	link	false	`/test hco-e2e-upgrade-index-sno-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-12-13T10:10:24Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2021-12-13T10:10:30Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 requested review from tiraboschi and nunnatsa December 5, 2021 22:33

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL labels Dec 5, 2021

kubevirt-bot requested a review from sradco December 5, 2021 22:34

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 5, 2021

orenc1 force-pushed the virtio_win_cm branch from 5d701e4 to ff0cc4c Compare December 5, 2021 22:48

orenc1 changed the title ~~Provide virtio-win pullspec in dedicated ConfigMap~~ [WIP]: Provide virtio-win pullspec in dedicated ConfigMap Dec 5, 2021

kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2021

orenc1 force-pushed the virtio_win_cm branch from ff0cc4c to bf0f80f Compare December 6, 2021 11:44

orenc1 mentioned this pull request Dec 6, 2021

Bug 2025295: Add new option for VIRTIOWIN ConfigMap name openshift/console#10616

Merged

orenc1 changed the title ~~[WIP]: Provide virtio-win pullspec in dedicated ConfigMap~~ Provide virtio-win pullspec in dedicated ConfigMap Dec 6, 2021

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2021

nunnatsa reviewed Dec 12, 2021

View reviewed changes

Generalize handlers for ConfigMaps, Roles and RoleBindings

f09bb23

Signed-off-by: orenc1 <ocohen@redhat.com>

orenc1 force-pushed the virtio_win_cm branch from 42bc768 to f09bb23 Compare December 12, 2021 13:42

kubevirt-bot assigned nunnatsa Dec 12, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2021

kubevirt-bot merged commit f06ce4b into kubevirt:main Dec 13, 2021

orenc1 deleted the virtio_win_cm branch December 13, 2021 10:11

		handler, _ := newConfigReaderRoleBindingHandler(logger, cl, commonTestUtils.GetScheme(), hco)
		res := handler[0].ensure(req)

Provide virtio-win pullspec in dedicated ConfigMap #1647

Provide virtio-win pullspec in dedicated ConfigMap #1647

Conversation

orenc1 commented Dec 5, 2021 • edited

hco-bot commented Dec 6, 2021

kubevirt-bot commented Dec 6, 2021

hco-bot commented Dec 6, 2021

kubevirt-bot commented Dec 6, 2021

hco-bot commented Dec 6, 2021

kubevirt-bot commented Dec 6, 2021

hco-bot commented Dec 6, 2021

kubevirt-bot commented Dec 6, 2021

hco-bot commented Dec 6, 2021

kubevirt-bot commented Dec 6, 2021

coveralls commented Dec 6, 2021 • edited

Pull Request Test Coverage Report for Build 1569610715

💛 - Coveralls

hco-bot commented Dec 6, 2021

kubevirt-bot commented Dec 6, 2021

hco-bot commented Dec 6, 2021

kubevirt-bot commented Dec 6, 2021

nunnatsa Dec 12, 2021

Choose a reason for hiding this comment

orenc1 Dec 12, 2021

Choose a reason for hiding this comment

nunnatsa Dec 12, 2021

Choose a reason for hiding this comment

orenc1 Dec 12, 2021

Choose a reason for hiding this comment

sonarcloud bot commented Dec 12, 2021

nunnatsa commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

hco-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

hco-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

hco-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

hco-bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

orenc1 commented Dec 12, 2021

nunnatsa commented Dec 12, 2021

openshift-ci bot commented Dec 12, 2021

kubevirt-bot commented Dec 12, 2021

nunnatsa commented Dec 12, 2021

nunnatsa commented Dec 13, 2021

orenc1 commented Dec 13, 2021

openshift-ci bot commented Dec 13, 2021 • edited

hco-bot commented Dec 13, 2021

kubevirt-bot commented Dec 13, 2021

orenc1 commented Dec 5, 2021 •

edited

coveralls commented Dec 6, 2021 •

edited

openshift-ci bot commented Dec 13, 2021 •

edited