Remove leftovers during upgrades #1824
Conversation
tiraboschi
added
the
do-not-merge/work-in-progress
kubevirt-bot
added
do-not-merge/release-note-label-needed
|
hco-e2e-upgrade-prev-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-upgrade-prev-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
upgrade_leftovers
branch
from
559876a
to
f5415c6
Compare
Pull Request Test Coverage Report for Build 2022558837
💛 - Coveralls |
|
hco-e2e-upgrade-prev-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-image-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
upgrade_leftovers
branch
from
f5415c6
to
1b800e6
Compare
|
hco-e2e-image-index-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
upgrade_leftovers
branch
from
1b800e6
to
86b51e9
Compare
|
hco-e2e-image-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiraboschi
force-pushed
the
upgrade_leftovers
branch
from
86b51e9
to
77788e5
Compare
tiraboschi
force-pushed
the
upgrade_leftovers
branch
from
77788e5
to
60abcc7
Compare
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| err := validateUpgradePatches(req) | ||
| if err != nil { | ||
| return reconcile.Result{Requeue: true}, err |
There was a problem hiding this comment.
Maybe I'm wrong here, but returning requeue=true won't solve the problem. The error will happen if we can't open the file, if its format is wrong. Another option is when the HyperConverged version is with a wrong format.
For the first cases WDYT about validating on boot, and fail the whole process? that way we could make sure we're releasing a valid file, because no test will run.
For the last one - maybe we can check the version in the create/update webhooks?
There was a problem hiding this comment.
If the json file is corrupted/wrong, requeue=true will not fix it for us.
But for sure the upgrade lanes will detect it so the risk of releasing with a broken file is really low.
On the other side, the earlier we fail the better it is.
There was a problem hiding this comment.
Still, returning requeue=true here may cause an endless loop - because nothing can fix these problems.
There was a problem hiding this comment.
Yes, right.
Moving it under if r.firstLoop {} with os.Exit(1) (and logging) on failures.
|
hco-e2e-upgrade-prev-index-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-index-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-upgrade-index-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Extend the UpgradePatches mechanism to be able to remove leftovers during upgrades according to a json configuration file. Start consuming it by removing v2v-vmware and vm-import-controller-config (not owned by HCO) ConfigMap when upgrading from versions <=1.6.0 In a future PR, other pieces of current code (removal of old SSP CRDs, old metrics, old quickstarts...) can be migrated to this generic mechanism. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2063991 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
force-pushed
the
upgrade_leftovers
branch
from
7a8765a
to
150630e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/retest |
|
@tiraboschi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-image-index-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherry-pick release-1.6 |
|
@tiraboschi: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tiraboschi: #1824 failed to apply on top of branch "release-1.6": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Extend the UpgradePatches mechanism to be able to remove leftovers during upgrades according to a json configuration file. Start consuming it by removing v2v-vmware and vm-import-controller-config (not owned by HCO) ConfigMap when upgrading from versions <=1.6.0 In a future PR, other pieces of current code (removal of old SSP CRDs, old metrics, old quickstarts...) can be migrated to this generic mechanism. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2063991 This is a manual cherry-pick of kubevirt#1824 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Extend the UpgradePatches mechanism to be able to remove leftovers during upgrades according to a json configuration file. Start consuming it by removing v2v-vmware and vm-import-controller-config (not owned by HCO) ConfigMap when upgrading from versions <=1.6.0 In a future PR, other pieces of current code (removal of old SSP CRDs, old metrics, old quickstarts...) can be migrated to this generic mechanism. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2063991 This is a manual cherry-pick of #1824 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Remove leftovers during upgrades
Extend the UpgradePatches mechanism
to be able to remove leftovers during
upgrades according to a json configuration
file.
Start consuming it by removing v2v-vmware and
vm-import-controller-config (not owned by HCO)
ConfigMap when upgrading from versions <=1.6.0
In a future PR, other pieces of current code
(removal of old SSP CRDs, old metrics,
old quickstarts...) can be migrated to
this generic mechanism.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=2063991
Signed-off-by: Simone Tiraboschi stirabos@redhat.com
Reviewer Checklist
Release note: