Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with openshift CI presubmit jobs #183

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Jul 24, 2019

  • Add Dockerfile.okd which is needed for the image stream builds
  • Add install target which will allows binary detection for streams
  • Extract the built image from IMAGE_FORMAT if running on okd ci
  • Change cmd dir to binary name to make go install work properly
  • Use the build image in cluster/sync.sh and hack/deploy.sh instead of published one

The corresponding presubmit job can be found in openshift/release#4494

Copy link
Contributor

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Optional comment added.

Makefile Outdated Show resolved Hide resolved
@rmohr
Copy link
Member Author

rmohr commented Jul 24, 2019

/hold

Will update the PR once I have everything sorted out on the integration branch.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2019
Makefile Outdated Show resolved Hide resolved
 * Add Dockerfile.okd which is needed for the image stream builds
 * Add install target which will allows binary detection for streams
 * Extract the built image from IMAGE_FORMAT if running on okd ci
 * Change cmd dir to binary name to make go install work properly
 * Use the build image in cluster/sync.sh and hack/deploy.sh instead of published one
@rmohr rmohr force-pushed the okd-presubmit-initial-preps branch from 2ce9c12 to 7e825ef Compare July 25, 2019 12:21
@rmohr
Copy link
Member Author

rmohr commented Jul 25, 2019

@rthallisey @djzager the job finally works: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/4494/rehearse-4494-pull-ci-kubevirt-hyperconverged-cluster-operator-integration-hco-e2e-aws/3.

In this job the deploy.sh script deployed HCO.

@rmohr rmohr changed the title Create initial targets for openshift CI Integrate with openshift CI presubmit jobs Jul 25, 2019
@rmohr
Copy link
Member Author

rmohr commented Jul 25, 2019

Once this PR is merged, I can switch the presubmit job to master, which will make it succeed on all tests there. After that we can assign someone to merge the presubmit job.

@rmohr
Copy link
Member Author

rmohr commented Jul 25, 2019

@rmohr
Copy link
Member Author

rmohr commented Jul 25, 2019

ci test please

@rmohr
Copy link
Member Author

rmohr commented Jul 25, 2019

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2019
_out
.idea

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's .idea?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the project folder from intellij IDEA (or goland).

Makefile Show resolved Hide resolved
@rthallisey rthallisey merged commit ec71df3 into kubevirt:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants