-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with openshift CI presubmit jobs #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Optional comment added.
/hold Will update the PR once I have everything sorted out on the |
* Add Dockerfile.okd which is needed for the image stream builds * Add install target which will allows binary detection for streams * Extract the built image from IMAGE_FORMAT if running on okd ci * Change cmd dir to binary name to make go install work properly * Use the build image in cluster/sync.sh and hack/deploy.sh instead of published one
2ce9c12
to
7e825ef
Compare
@rthallisey @djzager the job finally works: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/4494/rehearse-4494-pull-ci-kubevirt-hyperconverged-cluster-operator-integration-hco-e2e-aws/3. In this job the deploy.sh script deployed HCO. |
Once this PR is merged, I can switch the presubmit job to master, which will make it succeed on all tests there. After that we can assign someone to merge the presubmit job. |
one succeeded and one failed: https://kubevirt-master-stdci-production.apps.ovirt.org/job/kubevirt_hyperconverged-cluster-operator_standard-check-pr/132/artifact/ci_build_summary.html Will retrigger |
ci test please |
/hold cancel |
_out | ||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's .idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the project folder from intellij IDEA (or goland).
The corresponding presubmit job can be found in openshift/release#4494