Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] Fix 'ocp4-moderate-routes-protected-by-tls' Compliance failure #2042

Merged
merged 1 commit into from Jul 27, 2022
Merged

[release-1.7] Fix 'ocp4-moderate-routes-protected-by-tls' Compliance failure #2042

merged 1 commit into from Jul 27, 2022

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #2040

/assign tiraboschi

fix ocp4-moderate-routes-protected-by-tls compliance check fail.

@orenc1
Fix 'ocp4-moderate-routes-protected-by-tls' Compliance failure
0b60928 
According to:
https://github.com/ComplianceAsCode/content/blob/master/applications/openshift/networking/routes_protected_by_tls/rule.yml
All Routes on the cluster should have either 'None' or 'Redirect' setting under their .spec.tls.insecureEdgeTerminationPolicy
We chose 'Redirect', to be aligned with all other default routes on an OCP cluster, and not to fail HTTP requests but redirect them to HTTPS requests.

https://bugzilla.redhat.com/show_bug.cgi?id=2110562
Signed-off-by: Oren Cohen <ocohen@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 26, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request Jul 26, 2022
Merged
11 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2742464251

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 83.851%
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 88.1%
Totals Coverage Status
Change from base Build 2623749021: -0.02%
Covered Lines: 4294
Relevant Lines: 5121
💛 - Coveralls

orenc1
orenc1 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@hco-bot
Copy link
Collaborator

hco-bot commented Jul 26, 2022

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

@kubevirt-bot
Copy link
Contributor Author

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator

orenc1 commented Jul 27, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2022 •
edited

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-index-azure 0b60928 link true /test hco-e2e-upgrade-index-azure
ci/prow/hco-e2e-image-index-sno-azure 0b60928 link false /test hco-e2e-image-index-sno-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Jul 27, 2022

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

@kubevirt-bot
Copy link
Contributor Author

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator

orenc1 commented Jul 27, 2022

ignoring false positive from coveralls
/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor Author

@orenc1: Overrode contexts on behalf of orenc1: coverage/coveralls

In response to this:

ignoring false positive from coveralls
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 5240a05 into kubevirt:release-1.7 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@sradco sradco Awaiting requested review from sradco

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

Assignees

@tiraboschi tiraboschi

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubevirt-bot @coveralls @hco-bot @orenc1 @tiraboschi