fix CRModification alert in upgrade #2297

nunnatsa · 2023-03-23T14:46:29Z

The KubevirtHyperconvergedClusterOperatorCRModification alert is triggered on upgrade for some resource metrics.

This PR fixes this bug and prevents these alerts.

Reviewer Checklist

Jira Ticket:

https://issues.redhat.com/browse/CNV-22746

Release note:

Fix bug [https://issues.redhat.com/browse/CNV-22746] - should not trigger alerts during upgrade

coveralls · 2023-03-23T14:58:50Z

Pull Request Test Coverage Report for Build 4539993264

14 of 15 (93.33%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 85.103%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/alerts/reconciler.go	13	14	92.86%

Files with Coverage Reduction	New Missed Lines	%
controllers/alerts/reconciler.go	1	86.29%

Totals
Change from base Build 4535687233:	-0.002%
Covered Lines:	4993
Relevant Lines:	5867

💛 - Coveralls

hco-bot · 2023-03-23T16:08:03Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2023-03-23T16:08:12Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-23T16:31:31Z

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2023-03-23T16:31:38Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-sno-azure

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-23T17:51:58Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2023-03-23T17:52:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-03-24T09:23:12Z

/retest

tiraboschi · 2023-03-24T13:18:16Z

/retest

tiraboschi · 2023-03-24T17:18:00Z

/retest

nunnatsa · 2023-03-26T08:16:56Z

/retest

The KubevirtHyperconvergedClusterOperatorCRModification alert is triggered on upgrade for some resource metrics. This PR fixes this bug and prevents these alerts. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

hco-bot · 2023-03-26T13:51:31Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-03-26T13:51:34Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-26T14:03:05Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

kubevirt-bot · 2023-03-26T14:03:08Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-26T14:25:35Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

kubevirt-bot · 2023-03-26T14:25:38Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-26T14:51:42Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2023-03-26T14:51:46Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-03-26T15:19:52Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2023-03-26T15:19:59Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-upgrade-prev-index-sno-aws, ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-03-27T07:47:23Z

/retest

kubevirt-bot · 2023-03-28T08:29:06Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-03-28T09:05:39Z

/retest

hco-bot · 2023-03-28T09:06:49Z

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

kubevirt-bot · 2023-03-28T09:06:56Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-aws, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
hco-e2e-upgrade-prev-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2023-03-28T09:11:52Z

ignore tiny coverage gap
/override coverage/coveralls

kubevirt-bot · 2023-03-28T09:11:55Z

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

ignore tiny coverage gap
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-03-28T09:21:38Z

/approve

kubevirt-bot · 2023-03-28T09:21:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hco-bot · 2023-03-28T09:22:27Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-03-28T09:22:31Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2023-03-28T10:33:08Z

/override-bot

tiraboschi · 2023-03-28T11:10:25Z

/test okd-hco-e2e-image-index-gcp
/test okd-hco-e2e-image-index-aws

kubevirt-bot · 2023-03-28T11:10:28Z

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-hco-test-utils-image
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.24
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.25

Use /test all to run the following jobs that were automatically triggered:

pull-hyperconverged-cluster-operator-e2e-k8s-1.24
pull-hyperconverged-cluster-operator-e2e-k8s-1.25

In response to this:

/test okd-hco-e2e-image-index-gcp
/test okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-28T12:37:10Z

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-hco-e2e-upgrade-index-aws	`7d8633a`	link	true	`/test okd-hco-e2e-upgrade-index-aws`
ci/prow/hco-e2e-image-index-aws	`7d8633a`	link	true	`/test hco-e2e-image-index-aws`
ci/prow/hco-e2e-image-index-sno-azure	`7d8633a`	link	false	`/test hco-e2e-image-index-sno-azure`
ci/prow/hco-e2e-image-index-gcp	`7d8633a`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-upgrade-index-azure	`7d8633a`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-kv-smoke-azure	`7d8633a`	link	true	`/test hco-e2e-kv-smoke-azure`
ci/prow/okd-hco-e2e-image-index-aws	`7d8633a`	link	true	`/test okd-hco-e2e-image-index-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-03-28T12:48:14Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-03-28T12:48:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2023-03-28T13:49:40Z

/retest

hco-bot · 2023-03-28T15:32:54Z

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

kubevirt-bot · 2023-03-28T15:33:01Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-aws

In response to this:

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-03-29T09:37:27Z

/cherry-pick release-1.9

kubevirt-bot · 2023-03-29T09:38:07Z

@tiraboschi: new pull request created: #2305

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2023-03-29T12:02:56Z

/cherry-pick release-1.10

kubevirt-bot · 2023-03-29T12:03:32Z

@nunnatsa: cannot checkout release-1.10: error checking out release-1.10: exit status 1. output: error: pathspec 'release-1.10' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 23, 2023

nunnatsa requested a review from tiraboschi March 23, 2023 14:46

kubevirt-bot requested a review from machadovilaca March 23, 2023 14:46

kubevirt-bot added the size/L label Mar 23, 2023

nunnatsa requested a review from sradco March 23, 2023 14:46

fix CRModification alert in upgrade

7d8633a

The KubevirtHyperconvergedClusterOperatorCRModification alert is triggered on upgrade for some resource metrics. This PR fixes this bug and prevents these alerts. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

nunnatsa force-pushed the fix-CNV-22746 branch from 14975c3 to 1274e29 Compare March 26, 2023 12:36

tiraboschi approved these changes Mar 28, 2023

View reviewed changes

kubevirt-bot assigned tiraboschi Mar 28, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023

kubevirt-bot merged commit 87ff2ed into kubevirt:main Mar 28, 2023

kubevirt-bot mentioned this pull request Mar 29, 2023

[release-1.9] fix CRModification alert in upgrade #2305

Merged

nunnatsa deleted the fix-CNV-22746 branch March 29, 2023 12:02

fix CRModification alert in upgrade #2297

fix CRModification alert in upgrade #2297

Conversation

nunnatsa commented Mar 23, 2023

coveralls commented Mar 23, 2023 • edited

Pull Request Test Coverage Report for Build 4539993264

💛 - Coveralls

hco-bot commented Mar 23, 2023

kubevirt-bot commented Mar 23, 2023

hco-bot commented Mar 23, 2023

kubevirt-bot commented Mar 23, 2023

hco-bot commented Mar 23, 2023

kubevirt-bot commented Mar 23, 2023

tiraboschi commented Mar 24, 2023

tiraboschi commented Mar 24, 2023

tiraboschi commented Mar 24, 2023

nunnatsa commented Mar 26, 2023

hco-bot commented Mar 26, 2023

kubevirt-bot commented Mar 26, 2023

hco-bot commented Mar 26, 2023

kubevirt-bot commented Mar 26, 2023

hco-bot commented Mar 26, 2023

kubevirt-bot commented Mar 26, 2023

hco-bot commented Mar 26, 2023

kubevirt-bot commented Mar 26, 2023

hco-bot commented Mar 26, 2023

kubevirt-bot commented Mar 26, 2023

tiraboschi commented Mar 27, 2023

kubevirt-bot commented Mar 28, 2023

tiraboschi commented Mar 28, 2023

hco-bot commented Mar 28, 2023

kubevirt-bot commented Mar 28, 2023

nunnatsa commented Mar 28, 2023

kubevirt-bot commented Mar 28, 2023

tiraboschi commented Mar 28, 2023

kubevirt-bot commented Mar 28, 2023

hco-bot commented Mar 28, 2023

kubevirt-bot commented Mar 28, 2023

nunnatsa commented Mar 28, 2023

tiraboschi commented Mar 28, 2023

kubevirt-bot commented Mar 28, 2023

openshift-ci bot commented Mar 28, 2023 • edited

hco-bot commented Mar 28, 2023

kubevirt-bot commented Mar 28, 2023

nunnatsa commented Mar 28, 2023

hco-bot commented Mar 28, 2023

kubevirt-bot commented Mar 28, 2023

tiraboschi commented Mar 29, 2023

kubevirt-bot commented Mar 29, 2023

nunnatsa commented Mar 29, 2023

kubevirt-bot commented Mar 29, 2023

coveralls commented Mar 23, 2023 •

edited

openshift-ci bot commented Mar 28, 2023 •

edited