Use NodeSelector for kubevirt-console-plugin from HCO CR #2319

dharmit · 2023-04-17T14:55:12Z

What this PR does / why we need it:
It would help ensure kubevirt-console-plugin Pods respect the nodeSelector configuration

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-27446

Release note:

Place kubevirt-console-plugin Pod on NodeSelector specified in HCO CR

kubevirt-bot · 2023-04-17T14:55:22Z

Hi @dharmit. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2023-04-17T14:55:23Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nunnatsa for approval by writing /assign @nunnatsa in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-04-17T14:55:24Z

Hi @dharmit. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

controllers/operands/kubevirtConsolePlugin.go

machadovilaca · 2023-04-18T11:08:22Z

/ok-to-test

hco-bot · 2023-04-18T12:44:51Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

kubevirt-bot · 2023-04-18T12:45:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dharmit · 2023-04-19T07:47:51Z

The 1.25 tests are failing due to timeout on expecting "Available" condition of the deployment cert-manager-webhook.

The 1.24 tests are failing while expecting a VMI to be in running state. It's succeeding doing the same thing a few times before failing:

  Run 4/5
  STEP: Creating VMI... @ 04/18/23 14:09:52.653
  STEP: Verifying VMI is running @ 04/18/23 14:09:52.734
  [FAILED] in [It] - /home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/virtual_machines_test.go:39 @ 04/18/23 14:19:52.758
• [FAILED] [760.378 seconds]
[rfe_id:273][crit:critical][vendor:cnv-qe@redhat.com][level:system]Virtual Machine [It] [test_id:5696] should create, verify and delete VMIs
/home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/virtual_machines_test.go:35

and

  Run 7/20
  STEP: Creating VMI... @ 04/18/23 13:57:12.365
  STEP: Verifying VMI is running @ 04/18/23 13:57:12.38
  [FAILED] in [It] - /home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/node_placement_test.go:123 @ 04/18/23 14:07:12.381
• [FAILED] [661.399 seconds]
[rfe_id:4356][crit:medium][vendor:cnv-qe@redhat.com][level:system]Node Placement validate node placement for vmi [It] [test_id:5679] should create, verify and delete VMIs with correct node placements
/home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/node_placement_test.go:117
  [FAILED] Timed out after 600.001s.

@orenc1 @nunnatsa I could be wrong, but these tests look unrelated to the changes proposed in this PR. Should we just re-run the test?

controllers/operands/kubevirtConsolePlugin.go

hco-bot · 2023-04-26T11:23:06Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2023-04-26T11:23:09Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-04-26T11:31:27Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

kubevirt-bot · 2023-04-26T11:31:30Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-04-26T12:10:41Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2023-04-26T12:10:44Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-04-26T13:41:29Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

sonarcloud · 2023-05-30T06:26:26Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2023-05-30T07:31:37Z

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2023-05-30T07:31:40Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-05-30T07:41:25Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2023-05-30T07:41:28Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-05-30T07:51:41Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-05-30T07:51:44Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-05-30T08:08:19Z

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2023-05-30T08:08:25Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-05-30T08:24:59Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2023-05-30T08:25:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-05-30T10:05:34Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-05-30T10:05:39Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-05-30T13:13:02Z

/ok-to-test

hco-bot · 2023-05-30T14:51:38Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2023-05-30T14:51:44Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-05-30T15:04:51Z

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2023-05-30T15:05:03Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-05-30T15:32:35Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2023-05-30T15:32:42Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws, ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-05-30T17:30:54Z

@dharmit: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-prev-index-sno-aws	`1e945c7`	link	false	`/test hco-e2e-upgrade-prev-index-sno-aws`
ci/prow/hco-e2e-image-index-sno-aws	`1e945c7`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-image-index-sno-azure	`1e945c7`	link	false	`/test hco-e2e-image-index-sno-azure`
ci/prow/hco-e2e-image-index-aws	`1e945c7`	link	true	`/test hco-e2e-image-index-aws`
ci/prow/okd-hco-e2e-image-index-aws	`1e945c7`	link	true	`/test okd-hco-e2e-image-index-aws`
ci/prow/hco-e2e-upgrade-index-sno-aws	`1e945c7`	link	false	`/test hco-e2e-upgrade-index-sno-aws`
ci/prow/hco-e2e-upgrade-prev-index-aws	`1e945c7`	link	true	`/test hco-e2e-upgrade-prev-index-aws`
ci/prow/okd-hco-e2e-upgrade-index-gcp	`1e945c7`	link	true	`/test okd-hco-e2e-upgrade-index-gcp`
ci/prow/hco-e2e-image-index-azure	`1e945c7`	link	true	`/test hco-e2e-image-index-azure`
ci/prow/hco-e2e-upgrade-prev-index-azure	`1e945c7`	link	true	`/test hco-e2e-upgrade-prev-index-azure`
ci/prow/hco-e2e-upgrade-index-aws	`1e945c7`	link	true	`/test hco-e2e-upgrade-index-aws`
ci/prow/hco-e2e-upgrade-prev-index-sno-azure	`1e945c7`	link	false	`/test hco-e2e-upgrade-prev-index-sno-azure`
ci/prow/hco-e2e-kv-smoke-azure	`1e945c7`	link	true	`/test hco-e2e-kv-smoke-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-05-30T17:31:31Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-05-30T17:31:35Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-05-31T15:59:04Z

controllers/operands/kubevirtConsolePlugin.go

+	if hc.Spec.Infra.NodePlacement != nil {
+		deployment.Spec.Template.Spec.NodeSelector = hc.Spec.Infra.NodePlacement.NodeSelector
+		deployment.Spec.Template.Spec.Affinity = hc.Spec.Infra.NodePlacement.Affinity
+		deployment.Spec.Template.Spec.Tolerations = hc.Spec.Infra.NodePlacement.Tolerations


please correctly copy

tiraboschi · 2023-05-31T16:01:16Z

controllers/operands/kubevirtConsolePlugin_test.go

+				Expect(err).ToNot(HaveOccurred())
+
+				cl := commonTestUtils.InitClient([]runtime.Object{hco, existingResource})
+				handler := newConsoleHandler(cl)


wrong handler, this is not covering the piece of code you tried to fix

tiraboschi · 2023-05-31T16:01:18Z

controllers/operands/kubevirtConsolePlugin_test.go

+
+				Expect(existingResource.Spec.Template.Spec.NodeSelector).ToNot(BeNil())
+				Expect(foundResource.Spec.Template.Spec.NodeSelector).ToNot(BeNil())
+				Expect(foundResource.Spec.Template.Spec.NodeSelector).To(Equal(existingResource.Spec.Template.Spec.NodeSelector))


you are comparing the modified object with its initial state so you are basically ensuring that the code is doing nothing

tiraboschi · 2023-05-31T16:01:36Z

controllers/operands/kubevirtConsolePlugin_test.go

+				Expect(err).ToNot(HaveOccurred())
+
+				cl := commonTestUtils.InitClient([]runtime.Object{hco, existingResource})
+				handler := newConsoleHandler(cl)


tiraboschi · 2023-05-31T16:02:31Z

controllers/operands/kubevirtConsolePlugin_test.go

+				Expect(existingResource.Spec.Template.Spec.NodeSelector).To(BeNil())
+				Expect(foundResource.Spec.Template.Spec.NodeSelector).To(BeNil())


this is going to enforce that the code is doing nothing

dharmit · 2023-06-01T13:30:16Z

Closing in favour of #2361

/close

kubevirt-bot · 2023-06-01T13:30:19Z

@dharmit: Closed this PR.

In response to this:

Closing in favour of #2361

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 17, 2023

kubevirt-bot requested review from orenc1 and tiraboschi April 17, 2023 14:55

kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 17, 2023

kubevirt-bot added the size/XS label Apr 17, 2023

tiraboschi reviewed Apr 17, 2023

View reviewed changes

controllers/operands/kubevirtConsolePlugin.go Outdated Show resolved Hide resolved

kubevirt-bot added size/L and removed size/XS labels Apr 18, 2023

kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2023

This was referenced Apr 19, 2023

Adds notes to Developer Workflow docs #2286

Closed

Label and unlabel nodes in functional tests #2310

Merged

tiraboschi reviewed Apr 26, 2023

View reviewed changes

controllers/operands/kubevirtConsolePlugin.go Outdated Show resolved Hide resolved

kubevirt-bot added size/S and removed size/L labels Apr 26, 2023

Separate tests for node placement checks

1e945c7

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

dharmit force-pushed the fix-cnv-27446 branch from d8b8988 to 1e945c7 Compare May 30, 2023 06:25

tiraboschi reviewed May 31, 2023

View reviewed changes

kubevirt-bot closed this Jun 1, 2023

dharmit deleted the fix-cnv-27446 branch July 27, 2023 12:33

		Expect(existingResource.Spec.Template.Spec.NodeSelector).To(BeNil())
		Expect(foundResource.Spec.Template.Spec.NodeSelector).To(BeNil())

Use NodeSelector for kubevirt-console-plugin from HCO CR #2319

Use NodeSelector for kubevirt-console-plugin from HCO CR #2319

Conversation

dharmit commented Apr 17, 2023

kubevirt-bot commented Apr 17, 2023

kubevirt-bot commented Apr 17, 2023

openshift-ci bot commented Apr 17, 2023

machadovilaca commented Apr 18, 2023

hco-bot commented Apr 18, 2023

kubevirt-bot commented Apr 18, 2023

dharmit commented Apr 19, 2023

hco-bot commented Apr 26, 2023

kubevirt-bot commented Apr 26, 2023

hco-bot commented Apr 26, 2023

kubevirt-bot commented Apr 26, 2023

hco-bot commented Apr 26, 2023

kubevirt-bot commented Apr 26, 2023

hco-bot commented Apr 26, 2023

sonarcloud bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

tiraboschi commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

openshift-ci bot commented May 30, 2023

hco-bot commented May 30, 2023

kubevirt-bot commented May 30, 2023

tiraboschi May 31, 2023

Choose a reason for hiding this comment

tiraboschi May 31, 2023

Choose a reason for hiding this comment

tiraboschi May 31, 2023

Choose a reason for hiding this comment

tiraboschi May 31, 2023

Choose a reason for hiding this comment

tiraboschi May 31, 2023

Choose a reason for hiding this comment

dharmit commented Jun 1, 2023

kubevirt-bot commented Jun 1, 2023