Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s to v0.27.2 #2333

Merged
merged 1 commit into from Jun 8, 2023
Merged

Bump k8s to v0.27.2 #2333

merged 1 commit into from Jun 8, 2023

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented May 5, 2023

What this PR does / why we need it:
Bump k8s to v0.27.2 and sigs.k8s.io/controller-runtime v0.15.0-beta.0

  • github.com/onsi/ginkgo/v2 v2.9.2 => v2.9.5
  • github.com/onsi/gomega v1.27.6 => v1.27.7
  • github.com/openshift/library-go v0.0.0-20230411150541-a704a5774e20 => v0.0.0-20230516103935-9536341565eb
  • github.com/operator-framework/api v0.17.3 => v0.17.5
  • github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.64.0 => v0.65.1
  • github.com/prometheus/client_golang v1.15.0 => v1.15.1
  • github.com/prometheus/client_model v0.3.0 => v0.4.0
  • golang.org/x/tools v0.8.0 => v0.9.1
  • k8s.io/* v0.26.4 => v0.27.2
  • k8s.io/kube-openapi v0.0.0-20230327201221-f5883ff37f0c => v0.0.0-20230515203736-54b630e78af5
  • sigs.k8s.io/controller-runtime v0.14.6 => v0.15.0
  • sigs.k8s.io/controller-tools v0.11.3 => v0.12.0
  • github.com/openshift/machine-api-operator v0.2.1-0.20191025120018-fb3724fc7bdf => v0.2.1-0.20230329185430-d3973b45c2b6
  • github.com/gorilla/websocket v1.4.2 => v1.5.0

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

https://issues.redhat.com/browse/CNV-28604

Release note:

Bump k8s to v0.27.1 and sigs.k8s.io/controller-runtime v0.15.0-alpha.0

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 5, 2023
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 5, 2023
@@ -185,7 +185,7 @@ func getNewManagerCache(operatorNamespace string) cache.NewCacheFunc {
labelSelectorForNamespace := labels.Set{hcoutil.KubernetesMetadataName: operatorNamespace}.AsSelector()
return cache.BuilderWithOptions(
cache.Options{
SelectorsByObject: cache.SelectorsByObject{
ByObject: map[client.Object]cache.ByObject{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -160,7 +160,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, ci hcoutil.ClusterInfo) er

// Watch for changes to primary resource HyperConverged
err = c.Watch(
&source.Kind{Type: &hcov1beta1.HyperConverged{}},
source.Kind(mgr.GetCache(), &hcov1beta1.HyperConverged{}),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&source.Kind{Type: resource},
handler.EnqueueRequestsFromMapFunc(func(a client.Object) []reconcile.Request {
source.Kind(mgr.GetCache(), resource),
handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, a client.Object) []reconcile.Request {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -112,8 +112,9 @@ func (wh *WebhookHandler) Handle(ctx context.Context, req admission.Request) adm
return admission.Allowed("")
}

var _ admission.DecoderInjector = &WebhookHandler{}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 180 to 186
func InitClient(clientObjects []client.Object) *HcoTestClient {
// Create a fake client to mock API calls
cl := fake.NewClientBuilder().
WithRuntimeObjects(clientObjects...).
WithObjects(clientObjects...).
WithScheme(GetScheme()).
WithStatusSubresource(clientObjects...).
Build()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coveralls
Copy link
Collaborator

coveralls commented May 8, 2023

Pull Request Test Coverage Report for Build 5201132516

  • 45 of 57 (78.95%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 85.886%

Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/hyperconverged/hyperconverged_controller.go 21 26 80.77%
pkg/webhooks/validator/validator.go 3 10 30.0%
Files with Coverage Reduction New Missed Lines %
pkg/webhooks/validator/validator.go 2 88.67%
Totals Coverage Status
Change from base Build 5196013917: 0.1%
Covered Lines: 4929
Relevant Lines: 5739

💛 - Coveralls

@tiraboschi tiraboschi force-pushed the k8s_v0.27.1 branch 3 times, most recently from 90eedd9 to 4b506ca Compare May 15, 2023 07:57
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2023
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@tiraboschi tiraboschi force-pushed the k8s_v0.27.1 branch 2 times, most recently from f71d447 to 4ad1102 Compare May 19, 2023 08:28
@hco-bot
Copy link
Collaborator

hco-bot commented May 19, 2023

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented May 19, 2023

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented May 19, 2023

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi tiraboschi force-pushed the k8s_v0.27.1 branch 3 times, most recently from 8e0298a to 4ea8504 Compare May 19, 2023 14:23
@tiraboschi tiraboschi changed the title WIP: Bump k8s to v0.27.1 WIP: Bump k8s to v0.27.2 May 19, 2023
@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bump k8s to v0.27.2 and sigs.k8s.io/controller-runtime v0.15.0
- github.com/onsi/ginkgo/v2 v2.9.2 => v2.9.5
- github.com/onsi/gomega v1.27.6 => v1.27.7
- github.com/openshift/library-go v0.0.0-20230411150541-a704a5774e20 => v0.0.0-20230516103935-9536341565eb
- github.com/operator-framework/api v0.17.3 => v0.17.5
- github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.64.0 => v0.65.1
- github.com/prometheus/client_golang v1.15.0 => v1.15.1
- github.com/prometheus/client_model v0.3.0 => v0.4.0
- golang.org/x/tools v0.8.0 => v0.9.1
- k8s.io/* v0.26.4 => v0.27.2
- k8s.io/kube-openapi v0.0.0-20230327201221-f5883ff37f0c => v0.0.0-20230515203736-54b630e78af5
- sigs.k8s.io/controller-runtime v0.14.6 => v0.15.0
- sigs.k8s.io/controller-tools v0.11.3 => v0.12.0
- github.com/openshift/machine-api-operator v0.2.1-0.20191025120018-fb3724fc7bdf => v0.2.1-0.20230329185430-d3973b45c2b6
- github.com/gorilla/websocket v1.4.2 => v1.5.0

Signed-off-by: stirabos <stirabos@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 7, 2023

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 7, 2023

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 7, 2023

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 7, 2023

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 7, 2023

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 7, 2023

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-image-index-gcp e2deb1d link true /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-upgrade-prev-index-azure e2deb1d link true /test hco-e2e-upgrade-prev-index-azure
ci/prow/okd-hco-e2e-image-index-gcp e2deb1d link true /test okd-hco-e2e-image-index-gcp
ci/prow/hco-e2e-kv-smoke-azure e2deb1d link true /test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-upgrade-index-sno-azure e2deb1d link false /test hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-upgrade-index-azure e2deb1d link true /test hco-e2e-upgrade-index-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Jun 8, 2023

Great work!!! this one was not simple...

hco-e2e-upgrade-index-aws and hco-e2e-upgrade-index-sno-aws lanes passed.

/overide ci/prow/hco-e2e-upgrade-index-azure
/override ci/prow/hco-e2e-upgrade-index-sno-azure

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

Great work!!! this one was not simple...

hco-e2e-upgrade-index-aws and hco-e2e-upgrade-index-sno-aws lanes passed.

/overide ci/prow/hco-e2e-upgrade-index-azure
/override ci/prow/hco-e2e-upgrade-index-sno-azure

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@nunnatsa
Copy link
Collaborator

nunnatsa commented Jun 8, 2023

/override ci/prow/hco-e2e-upgrade-index-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-index-azure

In response to this:

/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 7ac82e8 into kubevirt:main Jun 8, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants