[release-1.9] Expose DisableMDEVConfiguration feature gate on HCO API #2367

tiraboschi · 2023-06-03T07:57:23Z

What this PR does / why we need it:

Expose DisableMDEVConfiguration feature gate on HCO API

This is a manual cherry pick of #2320
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2184439

Signed-off-by: Oren Cohen ocohen@redhat.com
Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-27889

Release note:

expose DisableMDEVConfiguration feature gate in HCO CR.

coveralls · 2023-06-03T08:03:50Z

Pull Request Test Coverage Report for Build 5338058788

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 85.79%

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	1	84.34%

Totals
Change from base Build 5331675909:	-0.01%
Covered Lines:	4878
Relevant Lines:	5686

💛 - Coveralls

hco-bot · 2023-06-03T09:03:58Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2023-06-03T09:04:00Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-03T09:17:17Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2023-06-03T09:17:21Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-06-03T10:29:35Z

/retest

hco-bot · 2023-06-03T12:09:49Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2023-06-03T12:09:53Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-03T12:37:41Z

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2023-06-03T12:37:47Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-06-03T15:51:50Z

/retest

tiraboschi · 2023-06-03T20:57:48Z

/retest

tiraboschi · 2023-06-04T12:41:32Z

/retest

tiraboschi · 2023-06-04T16:29:26Z

/retest

orenc1 · 2023-06-05T08:51:31Z

/retest

kubevirt-bot · 2023-06-05T09:09:05Z

@tiraboschi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-hyperconverged-cluster-operator-e2e-k8s-1.24	106461d7afe30e39b9a9c2d14494abc18c30fb20	link	true	`/test pull-hyperconverged-cluster-operator-e2e-k8s-1.24`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

orenc1 · 2023-06-14T14:20:21Z

to be able to merge this, we need to consume a kubevirt release on release-0.59 that includes this fix:
kubevirt/kubevirt#9856

@acardace , is there an ETA for tagging/releasing kubevirt v0.59.2 ?

acardace · 2023-06-14T15:22:38Z

to be able to merge this, we need to consume a kubevirt release on release-0.59 that includes this fix: kubevirt/kubevirt#9856

@acardace , is there an ETA for tagging/releasing kubevirt v0.59.2 ?

@davidvossel ?

…kubevirt#2320) * Expose DisableMDEVConfiguration feature gate on HCO API This is a manual cherry pick of kubevirt#2320 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2184439 Signed-off-by: Oren Cohen <ocohen@redhat.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2023-06-21T19:16:01Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2023-06-21T20:20:17Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2023-06-21T20:20:20Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-21T20:26:08Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2023-06-21T20:26:11Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-21T20:32:13Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

kubevirt-bot · 2023-06-21T20:32:16Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-21T20:51:34Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

kubevirt-bot · 2023-06-21T20:51:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

davidvossel · 2023-06-21T20:56:30Z

@acardace , is there an ETA for tagging/releasing kubevirt v0.59.2 ?

it's out now

hco-bot · 2023-06-21T21:03:20Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-06-21T21:03:23Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-06-21T22:52:24Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-prev-index-sno-azure	`15fd0f5`	link	false	`/test hco-e2e-upgrade-prev-index-sno-azure`
ci/prow/hco-e2e-upgrade-prev-index-azure	`15fd0f5`	link	true	`/test hco-e2e-upgrade-prev-index-azure`
ci/prow/hco-e2e-kv-smoke-azure	`15fd0f5`	link	true	`/test hco-e2e-kv-smoke-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-06-21T23:04:29Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-06-21T23:04:32Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 · 2023-06-22T06:22:51Z

@acardace , is there an ETA for tagging/releasing kubevirt v0.59.2 ?

it's out now

Thanks.
I saw, we bumped kubevirt on #2392 and I rebased this PR to use kubevirt 0.59.2.
Now CI has passed and we can merge.
/override coverage/coveralls
/lgtm

kubevirt-bot · 2023-06-22T06:22:54Z

@orenc1: Overrode contexts on behalf of orenc1: coverage/coveralls

In response to this:

@acardace , is there an ETA for tagging/releasing kubevirt v0.59.2 ?

it's out now

Thanks.
I saw, we bumped kubevirt on #2392 and I rebased this PR to use kubevirt 0.59.2.
Now CI has passed and we can merge.
/override coverage/coveralls
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 · 2023-06-22T06:25:35Z

/approve

kubevirt-bot · 2023-06-22T06:25:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [orenc1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jun 3, 2023

kubevirt-bot requested review from nunnatsa and orenc1 June 3, 2023 07:57

tiraboschi changed the title ~~R19 disable mdev configuration~~ [release-1.9] Expose DisableMDEVConfiguration feature gate on HCO API Jun 3, 2023

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2023

orenc1 force-pushed the r19_DisableMDEVConfiguration branch from 106461d to 15fd0f5 Compare June 21, 2023 19:15

kubevirt-bot added size/L and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Jun 21, 2023

kubevirt-bot assigned orenc1 Jun 22, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023

orenc1 approved these changes Jun 22, 2023

View reviewed changes

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023

kubevirt-bot merged commit d8cfc72 into kubevirt:release-1.9 Jun 22, 2023
25 checks passed

[release-1.9] Expose DisableMDEVConfiguration feature gate on HCO API #2367

[release-1.9] Expose DisableMDEVConfiguration feature gate on HCO API #2367

Conversation

tiraboschi commented Jun 3, 2023

coveralls commented Jun 3, 2023 • edited

Pull Request Test Coverage Report for Build 5338058788

💛 - Coveralls

hco-bot commented Jun 3, 2023

kubevirt-bot commented Jun 3, 2023

hco-bot commented Jun 3, 2023

kubevirt-bot commented Jun 3, 2023

tiraboschi commented Jun 3, 2023

hco-bot commented Jun 3, 2023

kubevirt-bot commented Jun 3, 2023

hco-bot commented Jun 3, 2023

kubevirt-bot commented Jun 3, 2023

tiraboschi commented Jun 3, 2023

tiraboschi commented Jun 3, 2023

tiraboschi commented Jun 4, 2023

tiraboschi commented Jun 4, 2023

orenc1 commented Jun 5, 2023

kubevirt-bot commented Jun 5, 2023

orenc1 commented Jun 14, 2023

acardace commented Jun 14, 2023

sonarcloud bot commented Jun 21, 2023

hco-bot commented Jun 21, 2023

kubevirt-bot commented Jun 21, 2023

hco-bot commented Jun 21, 2023

kubevirt-bot commented Jun 21, 2023

hco-bot commented Jun 21, 2023

kubevirt-bot commented Jun 21, 2023

hco-bot commented Jun 21, 2023

kubevirt-bot commented Jun 21, 2023

davidvossel commented Jun 21, 2023

hco-bot commented Jun 21, 2023

kubevirt-bot commented Jun 21, 2023

openshift-ci bot commented Jun 21, 2023

hco-bot commented Jun 21, 2023

kubevirt-bot commented Jun 21, 2023

orenc1 commented Jun 22, 2023

kubevirt-bot commented Jun 22, 2023

orenc1 commented Jun 22, 2023

kubevirt-bot commented Jun 22, 2023

coveralls commented Jun 3, 2023 •

edited