Propagate nodeplacement to kubevirt-console-plugin deployment #2384

dharmit · 2023-06-13T08:15:36Z

What this PR does / why we need it:

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Jira Ticket:

https://issues.redhat.com/browse/CNV-27446

Release note:

Place kubevirt-console-plugin Pod on NodeSelector specified in HCO CR

This PR is a rebased version of #2361.

It would help ensure kubevirt-console-plugin deployment respect the node placement configuration from the HCO CR. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

hco-bot · 2023-06-13T09:24:46Z

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

kubevirt-bot · 2023-06-13T09:24:50Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-operator-sdk-gcp

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-13T09:31:43Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2023-06-13T09:31:47Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-13T09:41:25Z

hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp

kubevirt-bot · 2023-06-13T09:41:29Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-gcp

In response to this:

hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-13T09:51:24Z

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2023-06-13T09:51:27Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure

In response to this:

hco-e2e-image-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-13T10:06:20Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-06-13T10:06:23Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-13T11:31:20Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-06-13T11:31:24Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dharmit · 2023-06-13T12:39:33Z

/retest

hco-bot · 2023-06-13T13:51:27Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

kubevirt-bot · 2023-06-13T13:51:31Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-06-13T14:03:52Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2023-06-13T14:03:59Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dharmit · 2023-06-14T11:58:39Z

/retest

Time out while bringing up VM.


  [FAILED] in [It] - /home/prow/go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/virtual_machines_test.go:39 @ 06/13/23 14:48:26.341
• [FAILED] [600.079 seconds]

nunnatsa

Added a few inline comments.

controllers/operands/kubevirtConsolePlugin_test.go

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

sonarcloud · 2023-06-15T11:11:15Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

coveralls · 2023-06-15T11:16:30Z

Pull Request Test Coverage Report for Build 5278070595

21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
138 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.08%) to 85.939%

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/ssp.go	9	94.62%
controllers/operands/operandHandler.go	10	84.15%
pkg/webhooks/validator/validator.go	17	90.48%
controllers/hyperconverged/hyperconverged_controller.go	102	81.61%

Totals
Change from base Build 5242571503:	0.08%
Covered Lines:	4926
Relevant Lines:	5732

💛 - Coveralls

nunnatsa

/approve

kubevirt-bot · 2023-06-15T12:01:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hco-bot · 2023-06-15T12:45:16Z

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-image-index-sno-aws, hco-e2e-image-index-sno-azure, hco-e2e-image-index-sno-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

kubevirt-bot · 2023-06-15T12:45:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-aws lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-image-index-sno-aws, hco-e2e-image-index-sno-azure, hco-e2e-image-index-sno-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-06-15T15:16:35Z

@dharmit: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-operator-sdk-gcp	`bd89110`	link	true	`/test hco-e2e-operator-sdk-gcp`
ci/prow/hco-e2e-image-index-sno-azure	`bd89110`	link	false	`/test hco-e2e-image-index-sno-azure`
ci/prow/hco-e2e-upgrade-index-sno-azure	`bd89110`	link	false	`/test hco-e2e-upgrade-index-sno-azure`
ci/prow/hco-e2e-kv-smoke-azure	`bd89110`	link	true	`/test hco-e2e-kv-smoke-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-06-15T15:20:13Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-06-15T15:20:17Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…rt#2384) * Propagate nodeplacement to kubevirt-console-plugin deployment It would help ensure kubevirt-console-plugin deployment respect the node placement configuration from the HCO CR. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> * Align function names with main branch Signed-off-by: Dharmit Shah <shahdharmit@gmail.com> * Use Nil/Empty checks instead of Zero in tests Signed-off-by: Dharmit Shah <shahdharmit@gmail.com> --------- Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> Signed-off-by: Dharmit Shah <shahdharmit@gmail.com> Co-authored-by: stirabos <stirabos@redhat.com>

…#2413) * Propagate nodeplacement to kubevirt-console-plugin deployment It would help ensure kubevirt-console-plugin deployment respect the node placement configuration from the HCO CR. * Align function names with main branch * Use Nil/Empty checks instead of Zero in tests --------- Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> Signed-off-by: Dharmit Shah <shahdharmit@gmail.com> Co-authored-by: stirabos <stirabos@redhat.com>

tiraboschi and others added 2 commits June 13, 2023 13:03

Propagate nodeplacement to kubevirt-console-plugin deployment

2f0d8cb

It would help ensure kubevirt-console-plugin deployment respect the node placement configuration from the HCO CR. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Align function names with main branch

d2496a9

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jun 13, 2023

kubevirt-bot requested review from nunnatsa and orenc1 June 13, 2023 08:26

nunnatsa reviewed Jun 15, 2023

View reviewed changes

Use Nil/Empty checks instead of Zero in tests

bd89110

Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>

nunnatsa approved these changes Jun 15, 2023

View reviewed changes

kubevirt-bot assigned nunnatsa Jun 15, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2023

kubevirt-bot merged commit a32957a into kubevirt:main Jun 15, 2023
28 checks passed

dharmit mentioned this pull request Jun 16, 2023

Propagate nodeplacement to kubevirt-console-plugin deployment #2361

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate nodeplacement to kubevirt-console-plugin deployment #2384

Propagate nodeplacement to kubevirt-console-plugin deployment #2384

dharmit commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

dharmit commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

dharmit commented Jun 14, 2023

nunnatsa left a comment

sonarcloud bot commented Jun 15, 2023

coveralls commented Jun 15, 2023

nunnatsa left a comment

kubevirt-bot commented Jun 15, 2023

hco-bot commented Jun 15, 2023

kubevirt-bot commented Jun 15, 2023

openshift-ci bot commented Jun 15, 2023

hco-bot commented Jun 15, 2023

kubevirt-bot commented Jun 15, 2023

Propagate nodeplacement to kubevirt-console-plugin deployment #2384

Propagate nodeplacement to kubevirt-console-plugin deployment #2384

Conversation

dharmit commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

dharmit commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

hco-bot commented Jun 13, 2023

kubevirt-bot commented Jun 13, 2023

dharmit commented Jun 14, 2023

nunnatsa left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jun 15, 2023

coveralls commented Jun 15, 2023

Pull Request Test Coverage Report for Build 5278070595

💛 - Coveralls

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Jun 15, 2023

hco-bot commented Jun 15, 2023

kubevirt-bot commented Jun 15, 2023

openshift-ci bot commented Jun 15, 2023

hco-bot commented Jun 15, 2023

kubevirt-bot commented Jun 15, 2023