fix "make bundleRegistry" error #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OKD-4.1.0 lane failed. The fix was already posted (not by me) on #244 |
|
/retest |
|
are you still seeing this on master? |
|
ci test please |
|
ci add to whitelist |
ffromani
force-pushed
the
bundle-registry-mro-fix
branch
from
3b88409
to
236d929
Compare
yep. One patch seems to be unneeded, so I removed from this PR. But the other is still needed. |
ffromani
force-pushed
the
bundle-registry-mro-fix
branch
from
236d929
to
d5bb3f8
Compare
Fixes this error: ``` time="2019-08-23T20:34:34Z" level=fatal msg="could not decode contents of file /registry/bundles.db into package: error converting YAML to JSON: yaml: control characters are not allowed" ``` Likely caused by the fact that the `initializer` tool mistakenly tries to include `bundles.db` into itself. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
bundle-registry-mro-fix
branch
from
d5bb3f8
to
33c57f3
Compare
djzager
approved these changes
Aug 28, 2019
|
Merging since this isn't really related to ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors preventing
make bundleRegistryto work on a clean tree snapshot