Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Managed-Tenant-Quota (MTQ) operator to the bundle #2461

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Add Managed-Tenant-Quota (MTQ) operator to the bundle #2461

merged 1 commit into from
Aug 8, 2023

Conversation

orenc1
Copy link
Collaborator

@orenc1 orenc1 commented Aug 7, 2023 •
edited

What this PR does / why we need it:
MTQ is a new operator intended to streamline VM migrations under resource quota constraints, when the quota limit is reached.
This operator will be shipped in HCO's bundle through OLM.

TODO (in a followup PR):

  • implement MTQ CR reconciliation by HCO controller.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

https://issues.redhat.com/browse/CNV-31716

Release note:

integrate mtq-operator

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 7, 2023
@orenc1 orenc1 changed the title Integrate Managed-Tenant-Quota (MTQ) operator in HCO [WIP] Integrate Managed-Tenant-Quota (MTQ) operator in HCO Aug 7, 2023
@kubevirt-bot kubevirt-bot added size/XXL do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 7, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 7, 2023 •
edited

Pull Request Test Coverage Report for Build 5784406581

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.202%
Totals Coverage Status
Change from base Build 5761127438: 0.0%
Covered Lines: 5023
Relevant Lines: 5827
💛 - Coveralls

@orenc1
Copy link
Collaborator Author

orenc1 commented Aug 7, 2023

Hi @Barakmor1 ,
There might be some dicrepancy in the API Group of the MTQ kind.
In the CSV, it is defined with v1beta1:
https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2461/files#diff-f90276d7fff90309ffabad6398e5ac3ca09849ac8f31041289d8a3d317693b57R111
but in the CRD file, the api version is v1alpha1:
https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2461/files#diff-7040136c3c651dafd213d83ff61b5c8fd28444cc17c1ffd5924134057a431783R27

please fix so we can proceed, thanks

@Barakmor1
Copy link
Member

Hi @Barakmor1 , There might be some dicrepancy in the API Group of the MTQ kind. In the CSV, it is defined with v1beta1: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2461/files#diff-f90276d7fff90309ffabad6398e5ac3ca09849ac8f31041289d8a3d317693b57R111 but in the CRD file, the api version is v1alpha1: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2461/files#diff-7040136c3c651dafd213d83ff61b5c8fd28444cc17c1ffd5924134057a431783R27

please fix so we can proceed, thanks

Thanks for letting me know,
It should be good now.

@orenc1
Integrate Managed-Tenant-Quota (MTQ) operator in HCO
2b68f97 
Signed-off-by: Oren Cohen <ocohen@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 7, 2023

okd-hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-aws
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-aws

In response to this:

okd-hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-aws
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 7, 2023

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure

In response to this:

hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-gcp
hco-e2e-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Aug 7, 2023

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator Author

orenc1 commented Aug 8, 2023

/retest

@orenc1
Copy link
Collaborator Author

orenc1 commented Aug 8, 2023 

 Summarizing 2 Failures:
  [FAIL] golden image test test image-streams check imagestream reconciliation [It] check the centos8 imagestream [data-import-coron]
  /go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/golden_image_test.go:118
  [FAIL] golden image test disable the feature [It] imageStream should be removed [data-import-coron]
  /go/src/github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests/golden_image_test.go:212

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023 •
edited

@orenc1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws 2b68f97 link false /test hco-e2e-upgrade-operator-sdk-sno-aws
ci/prow/hco-e2e-operator-sdk-aws 2b68f97 link true /test hco-e2e-operator-sdk-aws
ci/prow/okd-hco-e2e-operator-sdk-aws 2b68f97 link true /test okd-hco-e2e-operator-sdk-aws
ci/prow/hco-e2e-upgrade-operator-sdk-azure 2b68f97 link true /test hco-e2e-upgrade-operator-sdk-azure
ci/prow/hco-e2e-operator-sdk-gcp 2b68f97 link true /test hco-e2e-operator-sdk-gcp
ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure 2b68f97 link true /test hco-e2e-upgrade-prev-operator-sdk-azure
ci/prow/hco-e2e-kv-smoke-azure 2b68f97 link true /test hco-e2e-kv-smoke-azure
ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws 2b68f97 link true /test okd-hco-e2e-upgrade-operator-sdk-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@orenc1 orenc1 changed the title [WIP] Integrate Managed-Tenant-Quota (MTQ) operator in HCO Integrate Managed-Tenant-Quota (MTQ) operator in HCO Aug 8, 2023
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2023
@orenc1 orenc1 changed the title Integrate Managed-Tenant-Quota (MTQ) operator in HCO Add Managed-Tenant-Quota (MTQ) operator to the bundle Aug 8, 2023
@hco-bot
Copy link
Collaborator

hco-bot commented Aug 8, 2023

okd-hco-e2e-upgrade-operator-sdk-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws

In response to this:

okd-hco-e2e-upgrade-operator-sdk-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@nunnatsa
Copy link
Collaborator

nunnatsa commented Aug 8, 2023

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.26-centos9

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index-hco-bundle
  • /test ci-index-hco-upgrade-operator-sdk-bundle
  • /test hco-e2e-kv-smoke-azure
  • /test hco-e2e-kv-smoke-gcp
  • /test hco-e2e-operator-sdk-aws
  • /test hco-e2e-operator-sdk-azure
  • /test hco-e2e-operator-sdk-gcp
  • /test hco-e2e-upgrade-operator-sdk-aws
  • /test hco-e2e-upgrade-operator-sdk-azure
  • /test hco-e2e-upgrade-prev-operator-sdk-aws
  • /test hco-e2e-upgrade-prev-operator-sdk-azure
  • /test images
  • /test okd-ci-index-hco-bundle
  • /test okd-ci-index-hco-upgrade-operator-sdk-bundle
  • /test okd-hco-e2e-operator-sdk-aws
  • /test okd-hco-e2e-operator-sdk-gcp
  • /test okd-hco-e2e-upgrade-operator-sdk-aws
  • /test okd-hco-e2e-upgrade-operator-sdk-gcp
  • /test okd-images

The following commands are available to trigger optional jobs:

  • /test hco-e2e-operator-sdk-sno-aws
  • /test hco-e2e-operator-sdk-sno-azure
  • /test hco-e2e-upgrade-operator-sdk-sno-aws
  • /test hco-e2e-upgrade-operator-sdk-sno-azure
  • /test hco-e2e-upgrade-prev-operator-sdk-sno-aws
  • /test hco-e2e-upgrade-prev-operator-sdk-sno-azure

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.26-centos9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Aug 8, 2023

/cherry-pick release-1.10

@kubevirt-bot
Copy link
Contributor

@nunnatsa: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 928efed into kubevirt:main Aug 8, 2023
33 checks passed
@kubevirt-bot
Copy link
Contributor

@nunnatsa: #2461 failed to apply on top of branch "release-1.10":

Applying: Integrate Managed-Tenant-Quota (MTQ) operator in HCO
Using index info to reconstruct a base tree...
A	deploy/index-image/community-kubevirt-hyperconverged/1.11.0/manifests/kubevirt-hyperconverged-operator.v1.11.0.clusterserviceversion.yaml
A	deploy/olm-catalog/community-kubevirt-hyperconverged/1.11.0/manifests/kubevirt-hyperconverged-operator.v1.11.0.clusterserviceversion.yaml
M	deploy/operator.yaml
Falling back to patching base and 3-way merge...
Auto-merging deploy/operator.yaml
Auto-merging deploy/olm-catalog/community-kubevirt-hyperconverged/1.10.0/manifests/kubevirt-hyperconverged-operator.v1.10.0.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in deploy/olm-catalog/community-kubevirt-hyperconverged/1.10.0/manifests/kubevirt-hyperconverged-operator.v1.10.0.clusterserviceversion.yaml
Auto-merging deploy/index-image/community-kubevirt-hyperconverged/1.10.0/manifests/kubevirt-hyperconverged-operator.v1.10.0.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Integrate Managed-Tenant-Quota (MTQ) operator in HCO
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1 orenc1 deleted the integrate_mqt_operator branch August 8, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@sradco sradco Awaiting requested review from sradco

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@orenc1 @coveralls @Barakmor1 @hco-bot @kubevirt-bot @nunnatsa