Expose auto resource limits FG #2543
Conversation
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
release-note
|
Skipping CI for Draft Pull Request. |
|
/test pull-hyperconverged-cluster-operator-e2e-k8s-1.27 |
|
@fossedihelm: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // and if a resource quota with memory limits is associated with the creation namespace. | ||
| // Note: this feature is in Developer Preview. | ||
| // +optional | ||
| // +kubebuilder:default=false |
There was a problem hiding this comment.
I'd expect this also on lines 69 and 704.
There was a problem hiding this comment.
Nice catch! Thanks
There was a problem hiding this comment.
@tiraboschi Can I ask you why the persistentReservation is not there?
There was a problem hiding this comment.
Good point, this smells like a bug but our tests are not detecting it.
So the tests are not robust enough or kube builder become smarter and duplicating it is not needed anymore.
Let's investigate.
Pull Request Test Coverage Report for Build 6638296290
💛 - Coveralls |
|
SonarCloud Quality Gate failed.
|
|
closing and re-opening, to trigger sonar cloud. |
fossedihelm
force-pushed
the
add_autoresourcelimit_fg
branch
from
ff33676
to
599e6cf
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/rebase |
Expose a Feature Gate to configure auto resource limits on Kubevirt. Signed-off-by: fossedihelm <ffossemo@redhat.com>
The missing FGs are: - `deployVmConsoleProxy` - `disableMDevConfiguration` - `persistentReservation` - `enableManagedTenantQuota` Signed-off-by: fossedihelm <ffossemo@redhat.com>
hco-bot
force-pushed
the
add_autoresourcelimit_fg
branch
from
599e6cf
to
cbddb84
Compare
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@fossedihelm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws |
|
@fossedihelm: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@fossedihelm: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test hco-e2e-upgrade-prev-operator-sdk-sno-aws |
|
@fossedihelm: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test hco-e2e-upgrade-prev-operator-sdk-sno-azure |
|
@fossedihelm: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Expose a Feature Gate to configure
auto resource limits on Kubevirt.
Also, added missing FGs in
kubebuilder:defaultFG outer fields.The missing FGs were:
deployVmConsoleProxydisableMDevConfigurationpersistentReservationenableManagedTenantQuotaReviewer Checklist
Jira Ticket:
Release note: