Remove HCO readiness test in CSV v0.0.1 #258
Conversation
| @@ -1166,7 +1166,7 @@ spec: | |||
| exec: | |||
| command: | |||
| - stat | |||
| - /tmp/operator-sdk-ready | |||
| - / | |||
There was a problem hiding this comment.
Not sure what we are after here but if you needed to remove the readiness check..why not just remove the probe entirely?
There was a problem hiding this comment.
I agree with @djzager . It would be nice to have few lines in the commit message to explain why this change is needed.
There was a problem hiding this comment.
At the CSV 0.0.1 the readiness probe will always fail, and this will create an issue during the install and update.
There was a problem hiding this comment.
Not sure what we are after here but if you needed to remove the readiness check..why not just remove the probe entirely?
Saw it as a more elegant way to fix the readiness probe.
If you think that it's better the remove the whole section, I can do that as well, but IMHO it's not necessary.
The components used in v0.0.1 will never bring the system to the "HCO Ready" state, thus the readiness test should be removed in that version, in order to avoid issues with installation and update. Signed-off-by: Lev Veyde <lveyde@redhat.com>
lveyde
force-pushed
the
remove-hco-readiness-test-in-v0.0.1
branch
from
cfa4012
to
90a3abe
Compare
|
ci test please |
Signed-off-by: Lev Veyde lveyde@redhat.com