Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the jq command to print out all versions #261

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

rthallisey
Copy link

The last item in the list isn't always the newest bundle. We might as well print out all the bundles that exist.

Copy link
Contributor

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are showing all the bundles, but why remove the while?

@rthallisey
Copy link
Author

The while was making sure the user doesn't input the same value as the latest bundle. It's hard in bash to figure out the latest x.y.z value. However, the user isn't completely out in the cold, the push step will fail if a duplicate bundle already exists.

@djzager djzager merged commit cee30d9 into kubevirt:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants