Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conditions in hco functional test #264

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Use conditions in hco functional test #264

merged 1 commit into from
Sep 17, 2019

Conversation

djzager
Copy link
Contributor

@djzager djzager commented Aug 29, 2019

No description provided.

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@rthallisey
Copy link

ci add to whitelist

rthallisey
rthallisey approved these changes Aug 30, 2019
View reviewed changes
Copy link

@rthallisey rthallisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@rthallisey
Copy link

ci test please

3 similar comments
@djzager
Copy link
Contributor Author

djzager commented Sep 3, 2019

ci test please

@rthallisey
Copy link

ci test please

@rthallisey
Copy link

ci test please

@rthallisey
Copy link

try rebasing this to see if it fixes ci

@djzager djzager force-pushed the functional-conditions branch 2 times, most recently from 18f7b19 to 882b195 Compare September 17, 2019 12:40
@djzager
Use conditions in hco functional test
d952170 
Signed-off-by: David Zager <dzager@redhat.com>
@djzager
Copy link
Contributor Author

djzager commented Sep 17, 2019

/test hco-e2e-aws

@rthallisey rthallisey merged commit 720daa6 into kubevirt:master Sep 17, 2019
@djzager djzager deleted the functional-conditions branch September 19, 2019 15:18
djzager added a commit to djzager/hyperconverged-cluster-operator that referenced this pull request Sep 25, 2019
@djzager
Use conditions in hco functional test (kubevirt#264)
58f78a9 
Signed-off-by: David Zager <dzager@redhat.com>
djzager added a commit that referenced this pull request Sep 25, 2019
@djzager
[release-2.1] Use conditions in hco functional test (#307)
b218e9f 
* Use conditions in hco functional test (#264)

Signed-off-by: David Zager <dzager@redhat.com>

* Update wait to 10 minutes

Signed-off-by: David Zager <dzager@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rthallisey rthallisey rthallisey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djzager @ovirt-infra @rthallisey