Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move v2vvmware CRD under v2v.kubevirt.io API group #519

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

mareklibra
Copy link
Contributor

Former group: kubevirt.io

Release note:

The v2vvmware CRD has been moved from the kubevirt.io API group to the v2v.kubevirt.io.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 1, 2020
@mareklibra mareklibra changed the title Move v2vvmware CRD under v2v.kubevirt.io API group WIP Move v2vvmware CRD under v2v.kubevirt.io API group Apr 1, 2020
@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS labels Apr 1, 2020
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 1, 2020
@mareklibra mareklibra changed the title WIP Move v2vvmware CRD under v2v.kubevirt.io API group Move v2vvmware CRD under v2v.kubevirt.io API group Apr 1, 2020
@kubevirt-bot kubevirt-bot added size/S and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS labels Apr 1, 2020
@tiraboschi tiraboschi force-pushed the v2v.kubevirt.io branch 2 times, most recently from efbd1f3 to 3cd8ac1 Compare April 1, 2020 19:23
@mareklibra
Copy link
Contributor Author

/retest

@mareklibra
Copy link
Contributor Author

@tiraboschi , can you have a look at the failing CI tests here, please? Is it a flake? Thank you.

@tiraboschi
Copy link
Member

@tiraboschi , can you have a look at the failing CI tests here, please? Is it a flake? Thank you.

In order to be able to test this we have to merge #506 and then rebase this one

Former group: kubevirt.io

Signed-off-by: Marek Libra <mlibra@redhat.com>
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2020
@mareklibra
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit d741082 into kubevirt:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants