Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate Negative Conditions #564

Merged
merged 7 commits into from May 20, 2020
Merged

Aggregate Negative Conditions #564

merged 7 commits into from May 20, 2020

Conversation

nunnatsa
Copy link
Collaborator

Make sure that when a sub component returns a negative condition (e.g. Available = "False" or Progressing = "True"), HCO will set all its conditions, and won't have left overs conditions from previous reconciliations.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels May 12, 2020
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented May 16, 2020 •
edited

/retest

@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

@nunnatsa nunnatsa requested a review from tiraboschi May 18, 2020 07:51
@nunnatsa nunnatsa changed the title Aggregate Negative Conditions WIP - Aggregate Negative Conditions May 18, 2020
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2020
@nunnatsa nunnatsa changed the title WIP - Aggregate Negative Conditions Aggregate Negative Conditions May 18, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2020
@nunnatsa
Aggregate Negative Conditions
da3d67c 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Fix code review comments. Make sure that all the the conditions are a…
accdac4 
…lways set.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
more accurate condition aggregation
2cdbc88 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Copy link
Collaborator Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
apply code review comment
a890c70 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Activity chart: PNG => SVG
8fe9819 
Build the chart automatically using `make sanity`, or run `./hack/build-charts.sh`

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Remove build-charts.sh from make sanity. The SVG metadata contains …
9b58c72 
…environment depended data that differ the SVG file and fails the sanity.

Add `make charts` in order to build the charts

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
fix code review comments
bfcda63 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2020
@tiraboschi
Copy link
Member

/approve
/lgtm

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@kubevirt-bot kubevirt-bot merged commit 68aa5ea into kubevirt:master May 20, 2020
@nunnatsa nunnatsa deleted the aggregate-conditions branch May 20, 2020 09:50
@nunnatsa nunnatsa mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@rthallisey rthallisey Awaiting requested review from rthallisey

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nunnatsa @openshift-ci-robot @tiraboschi @kubevirt-bot