Create a PriorityClass for KubeVirt on startup #669

yuvalturg · 2020-06-29T16:57:05Z

Until now, the PriorityClass for KubeVirt was created during
reconciliation (after creating the CR for the HCO). This caused the
virt-operator to exit with a FailedCreate status, and the CSV to stay in
a Failed status.
This patch creates the PriorityClass when the HCO starts, allowing the
virt-operator to be installed properly and the CSV's status to change to
Succeeded.

Signed-off-by: Yuval Turgeman yturgema@redhat.com

Release note:

Create KubeVirt's PriorityClass when HCO starts (BZ#1851856)

Until now, the PriorityClass for KubeVirt was created during reconciliation (after creating the CR for the HCO). This caused the virt-operator to exit with a FailedCreate status, and the CSV to stay in a Failed status. This patch creates the PriorityClass when the HCO starts, allowing the virt-operator to be installed properly and the CSV's status to change to Succeeded. Signed-off-by: Yuval Turgeman <yturgema@redhat.com>

ovirt-infra · 2020-06-29T16:57:07Z

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

pkg/util/util.go

tiraboschi · 2020-06-30T09:06:13Z

/test hco-e2e-upgrade-aws

kubevirt-bot · 2020-06-30T09:06:16Z

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2020-06-30T11:02:26Z

/override coverage/coveralls
ignoring slightly reduced coverage

kubevirt-bot · 2020-06-30T11:02:30Z

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

/override coverage/coveralls
ignoring slightly reduced coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2020-06-30T11:02:40Z

/test hco-e2e-upgrade-aws

kubevirt-bot · 2020-06-30T11:02:43Z

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2020-06-30T11:07:46Z

/approve

kubevirt-bot · 2020-06-30T11:08:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi · 2020-06-30T12:51:33Z

/test hco-e2e-upgrade-aws

kubevirt-bot · 2020-06-30T12:51:35Z

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

KV Priority Class is needed to start virt-operator but OLM is currently not able to create it so HCO is trying to create it ASAP. With #669 we are trying to create it as soon as HCO starts. But, for the same reason, we should not trying to delete it it when the user deletes HCO CR because virt-operator should continue running even if HCO CR got deleted. In the past we were trying to delete the priority class but we was failing on that just because we forgot to set app label on that and componentResourceRemoval is explictly checking for that before really deleting. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

tiraboschi · 2020-07-06T11:54:11Z

/cherry-pick release-2.4

kubevirt-bot · 2020-07-06T11:54:18Z

@tiraboschi: #669 failed to apply on top of branch "release-2.4":

Using index info to reconstruct a base tree...
M	cmd/hyperconverged-cluster-operator/main.go
M	pkg/controller/hyperconverged/hyperconverged_controller.go
A	pkg/controller/hyperconverged/hyperconverged_controller_components_test.go
A	pkg/controller/hyperconverged/testUtils_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/controller/hyperconverged/testUtils_test.go deleted in HEAD and modified in Create a PriorityClass for KubeVirt on startup. Version Create a PriorityClass for KubeVirt on startup of pkg/controller/hyperconverged/testUtils_test.go left in tree.
CONFLICT (modify/delete): pkg/controller/hyperconverged/hyperconverged_controller_components_test.go deleted in HEAD and modified in Create a PriorityClass for KubeVirt on startup. Version Create a PriorityClass for KubeVirt on startup of pkg/controller/hyperconverged/hyperconverged_controller_components_test.go left in tree.
Auto-merging pkg/controller/hyperconverged/hyperconverged_controller.go
Auto-merging cmd/hyperconverged-cluster-operator/main.go
CONFLICT (content): Merge conflict in cmd/hyperconverged-cluster-operator/main.go
error: Failed to merge in the changes.
Patch failed at 0001 Create a PriorityClass for KubeVirt on startup

In response to this:

/cherry-pick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Until now, the PriorityClass for KubeVirt was created during reconciliation (after creating the CR for the HCO). This caused the virt-operator to exit with a FailedCreate status, and the CSV to stay in a Failed status. This patch creates the PriorityClass when the HCO starts, allowing the virt-operator to be installed properly and the CSV's status to change to Succeeded. Signed-off-by: Yuval Turgeman <yturgema@redhat.com>

kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 29, 2020

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 29, 2020

kubevirt-bot requested review from nunnatsa and rwsu June 29, 2020 16:57

kubevirt-bot added the size/M label Jun 29, 2020

tiraboschi reviewed Jun 29, 2020

View reviewed changes

pkg/util/util.go Show resolved Hide resolved

tiraboschi approved these changes Jun 30, 2020

View reviewed changes

kubevirt-bot assigned tiraboschi Jun 30, 2020

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020

tiraboschi mentioned this pull request Jun 30, 2020

Avoid deleting KubeVirt Priority Class #670

Merged

kubevirt-bot merged commit 2ce1888 into kubevirt:master Jun 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a PriorityClass for KubeVirt on startup #669

Create a PriorityClass for KubeVirt on startup #669

yuvalturg commented Jun 29, 2020

ovirt-infra commented Jun 29, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jul 6, 2020

kubevirt-bot commented Jul 6, 2020

Create a PriorityClass for KubeVirt on startup #669

Create a PriorityClass for KubeVirt on startup #669

Conversation

yuvalturg commented Jun 29, 2020

ovirt-infra commented Jun 29, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jun 30, 2020

kubevirt-bot commented Jun 30, 2020

tiraboschi commented Jul 6, 2020

kubevirt-bot commented Jul 6, 2020