Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ensureKubeVirtStorageConfig #690

Merged
merged 1 commit into from Jul 30, 2020
Merged

Simplify ensureKubeVirtStorageConfig #690

merged 1 commit into from Jul 30, 2020

Conversation

maya-r
Copy link
Contributor

@maya-r maya-r commented Jul 7, 2020

As discussed in #498, this function only has upgrade logic because it's called by reconcile.
By calling it from ensureCDI we can drop the upgrade logic.

Catch up with this signature in tests.

Release note:

NONE

@maya-r
Simplify ensureKubeVirtStorageConfig.
0113929 
This function only has upgrade logic because it's called by
reconcile. By calling it from ensureCDI we can drop the
upgrade logic.

Catch up with this signature in tests.

Signed-off-by: Maya Rashish <mrashish@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 7, 2020
@ovirt-infra
Copy link

All tests passed

@nunnatsa
Copy link
Collaborator

/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@nunnatsa
Copy link
Collaborator

/rebase

@nunnatsa
Copy link
Collaborator

/retest

3 similar comments
@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa
Copy link
Collaborator

/approve

/lgtm

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@kubevirt-bot kubevirt-bot merged commit f7c4aa4 into kubevirt:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maya-r @ovirt-infra @nunnatsa @kubevirt-bot