Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValidateUpdate on the validating webhook #847

Merged
merged 1 commit into from Oct 1, 2020
Merged

Fix ValidateUpdate on the validating webhook #847

merged 1 commit into from Oct 1, 2020

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Oct 1, 2020 •
edited

Fix ValidateUpdate on the validating webhook

Fix ValidateUpdate on the validating webhook
properling looking up for existing objects
correctly initializing their names.

Fixes: https://bugzilla.redhat.com/1884138

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Release note:

Fix ValidateUpdate on the validating webhook

@tiraboschi
Fix ValidateUpdate on the validating webhook
6062498 
Fix ValidateUpdate on the validating webhook
properling looking up for existing objects
correctly initializing their names.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Oct 1, 2020
@ovirt-infra
Copy link

All tests passed

nunnatsa
nunnatsa reviewed Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@yuvalturg
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@hco-bot
Copy link
Collaborator

hco-bot commented Oct 1, 2020

hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 1, 2020

/test hco-e2e-upgrade-prev-aws
/test hco-e2e-aws
/test hco-e2e-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-aws
/test hco-e2e-aws
/test hco-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 1, 2020

/test hco-e2e-aws
/test hco-e2e-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-aws
/test hco-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 1, 2020

/retest

@nunnatsa nunnatsa closed this Oct 1, 2020
@nunnatsa nunnatsa reopened this Oct 1, 2020
@ovirt-infra
Copy link

All tests passed

@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 1, 2020

/test hco-e2e-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-upgrade-prev-aws 6062498 link /test hco-e2e-upgrade-prev-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 1, 2020

/override ci/prow/hco-e2e-upgrade-prev-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-prev-aws

In response to this:

/override ci/prow/hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 1, 2020

/override ci/prow/hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-azure

In response to this:

/override ci/prow/hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit fb87b8b into kubevirt:master Oct 1, 2020
@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 1, 2020

/cherry-pick release-1.2

@kubevirt-bot kubevirt-bot mentioned this pull request Oct 1, 2020
Merged
@kubevirt-bot
Copy link
Contributor

@nunnatsa: new pull request created: #852

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi tiraboschi mentioned this pull request Oct 1, 2020
Closed
@tiraboschi tiraboschi deleted the fix_validatewh_update_2 branch October 4, 2020 07:39
@tiraboschi tiraboschi added the hacktoberfest-accepted PRs accepted for hacktoberfest2020 label Oct 27, 2020
@kubevirt-bot
Copy link
Contributor

@nunnatsa: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/kubevirt-bot/hyperconverged-cluster-operator\n ! [rejected] cherry-pick-847-to-release-1.2 -> cherry-pick-847-to-release-1.2 (non-fast-forward)\nerror: failed to push some refs to 'https://kubevirt-bot:CENSORED@github.com/kubevirt-bot/hyperconverged-cluster-operator'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa left review comments

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@yuvalturg yuvalturg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. hacktoberfest-accepted PRs accepted for hacktoberfest2020 lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tiraboschi @ovirt-infra @kubevirt-bot @yuvalturg @hco-bot @nunnatsa @openshift-ci-robot