This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
update dockerhub images url #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copejon
reviewed
May 30, 2018
roles/cdi/defaults/main.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| cdi_namespace: "{{ cdi_image_namespace | default('golden-images') }}" | |||
| cdi_storageclass: "{{ cdi_kubevirt_storageclass | default('kubevirt') }}" | |||
| apb_action: "provision" | |||
| repo_tag: "{{ cdi_repo_tag | default('jcoperh') }}" | |||
| repo_tag: "{{ cdi_repo_tag | default('kubevirt') }}" | |||
| release_tag: "{{ cdi_release_tag | default('latest') }}" | |||
There was a problem hiding this comment.
release tags should reflect the most recent kubevirt version. The :latest tag is deliberately not used. Instead, CDI tracks kubevirt versions so as to ensure new kubevirt versions always use the most recent compatible version of CDI.
|
@shiywang Line 5 of roles/cdi/defaults/main.yml has |
Signed-off-by: Shiyang Wang <shiywang@redhat.com>
|
@shiywang lgtm! |
|
/lgtm |
lukas-bednar
approved these changes
Jun 6, 2018
|
Thank you! |
alexxa
pushed a commit
to alexxa/kubevirt-ansible
that referenced
this pull request
Jul 23, 2018
Signed-off-by: Shiyang Wang <shiywang@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #237
@aglitke @copejon @screeley44 PTAL
Signed-off-by: Shiyang Wang shiywang@redhat.com