Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase emptyDir size in modify-windows-iso-file task to 12Gi #233

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Mar 20, 2023

What this PR does / why we need it:
fix: increase emptyDir size in modify-windows-iso-file task to 12Gi

When using larger windows iso, 7Gi might not be enought. This commit increases the emptyFolder size to 12Gi which should be enough for most of the use cases.

Which issue(s) this PR fixes:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2177279

Special notes for your reviewer:

Release note:

 increase emptyDir size in modify-windows-iso-file task to 12Gi

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2177279
When using larger windows iso, 7Gi might not be enought. This commit
increases the emptyFolder size to 12Gi which should be enough for most
of the use cases.

Signed-off-by: Karel Šimon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Mar 20, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksimon1 ksimon1 merged commit 396d077 into kubevirt:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants