-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add link to example configmaps for pipelines to README of each #359
Conversation
Skipping CI for Draft Pull Request. |
Nice addition! It looks good to me, I'm not dropping the lgtm tag jet to give the chance to others to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a nit but how about making it a second sentence following the first sentence of the paragraph instead?
6535312
to
2e3514b
Compare
Updated |
pipeline this commit adds a link to example configmaps for each pipeline in each pipeline's README. Signed-off-by: Karel Simon <ksimon@redhat.com>
2e3514b
to
4d7d3ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix, ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ksimon1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
chore: add link to example configmaps for pipelines to README of each pipeline
this commit adds a link to example configmaps for each pipeline in each pipeline's README.
Release note:
@akrejcir, @jcanocan, @0xFelix