Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add link to example configmaps for pipelines to README of each #359

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Apr 2, 2024

What this PR does / why we need it:
chore: add link to example configmaps for pipelines to README of each pipeline

this commit adds a link to example configmaps for each pipeline in each pipeline's README.

Release note:

NONE

@akrejcir, @jcanocan, @0xFelix

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 2, 2024
Copy link

openshift-ci bot commented Apr 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ksimon1 ksimon1 marked this pull request as ready for review April 2, 2024 12:28
@kubevirt-bot kubevirt-bot added size/S and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 2, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@jcanocan
Copy link
Contributor

jcanocan commented Apr 2, 2024

Nice addition! It looks good to me, I'm not dropping the lgtm tag jet to give the chance to others to take a look.

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a nit but how about making it a second sentence following the first sentence of the paragraph instead?

@ksimon1
Copy link
Member Author

ksimon1 commented Apr 2, 2024

It's just a nit but how about making it a second sentence following the first sentence of the paragraph instead?

Updated

pipeline

this commit adds a link to example configmaps for each pipeline in each
pipeline's README.

Signed-off-by: Karel Simon <ksimon@redhat.com>
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
Copy link

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 2, 2024

@ksimon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 4d7d3ec link true /test e2e-tests
ci/prow/win10-pipeline-example-test 4d7d3ec link true /test win10-pipeline-example-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ksimon1 ksimon1 merged commit 68daae0 into kubevirt:main Apr 3, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants