Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: changed pip by pip3 in order to use python to execute ansible #111

Merged
merged 11 commits into from
Oct 17, 2019
Merged

Fix: changed pip by pip3 in order to use python to execute ansible #111

merged 11 commits into from
Oct 17, 2019

Conversation

jparrill
Copy link
Contributor

Fixing #109

@jparrill jparrill force-pushed the bug/fix_py2_deprecation branch 4 times, most recently from e218a75 to c3ab473 Compare August 22, 2019 15:47
@jparrill
Copy link
Contributor Author

Humm as we could see here: https://prow.apps.ovirt.org/log?id=1164565008722432000&job=kubevirt-tutorial-presubmit-lab-testing-k8s-1.13.3

and concretelly:

The following packages have unmet dependencies:
 python3-pip : Depends: python3-distutils but it is not installable
               Depends: python-pip-whl (= 18.1-5) but 9.0.1-2+deb9u1 is to be installed
               Recommends: python3-dev (>= 3.2) but it is not installable
               Recommends: python3-setuptools but it is not installable
               Recommends: python3-wheel but it is not installable

Python3 has so many deps not installed, the thing is if we install all the deps by hand we will lose much time for every job execution, and the image used is not managed by us.

The other option is use apt strategy but it fails on execution: https://prow.apps.ovirt.org/log?id=1164570046417080320&job=kubevirt-tutorial-presubmit-lab-testing-k8s-1.13.3

Preparing to unpack .../libc-bin_2.28-10_amd64.deb ...
Unpacking libc-bin (2.28-10) over (2.24-11+deb9u4) ...
dpkg: error processing archive /var/cache/apt/archives/libc-bin_2.28-10_amd64.deb (--unpack):
 unable to clean up mess surrounding './etc/default/nss' before installing another version: Read-only file system
dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
Errors were encountered while processing:
 /var/cache/apt/archives/libc-bin_2.28-10_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

@jparrill
Copy link
Contributor Author

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2019
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/M and removed size/S labels Oct 14, 2019
@iranzo
Copy link
Contributor

iranzo commented Oct 14, 2019

/retest

@iranzo iranzo force-pushed the bug/fix_py2_deprecation branch 2 times, most recently from 3dd916a to 05ccb1c Compare October 14, 2019 11:01
@iranzo
Copy link
Contributor

iranzo commented Oct 15, 2019

/retest

@iranzo iranzo force-pushed the bug/fix_py2_deprecation branch 4 times, most recently from 96303f4 to 97da77d Compare October 16, 2019 12:10
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 16, 2019
@iranzo iranzo force-pushed the bug/fix_py2_deprecation branch 2 times, most recently from d3eba6a to 32c85ef Compare October 17, 2019 07:52
@jparrill @iranzo
Fix: changed pip by pip3 in order to use python to execute ansible
46a3dc6 
Coauthored by:  Juan Manuel Parrilla Madrid <jparrill@redhat.com>
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Bump to 0.22.0
950415d 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Precreate bin folder
730fd52 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Install python3 kubernetes
7c11eb2 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Add openshift python library
d863756 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Update alternatives to use python3
d53bf04 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Allow extra spacing
0e327dc 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Stop the vm via mdsh
6821aa5 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Show source of test
3144d38 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Remove wait for vm to be ready
632aaa3 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@iranzo
Re-add bc manually
60fc16e 
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@jparrill
Copy link
Contributor Author

/lgtm

@kubevirt-bot
Copy link

@jparrill: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iranzo
Copy link
Contributor

iranzo commented Oct 17, 2019

/lgtm

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2019
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iranzo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@iranzo
Copy link
Contributor

iranzo commented Oct 17, 2019

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@kubevirt-bot kubevirt-bot merged commit fecc737 into kubevirt:master Oct 17, 2019
@iranzo iranzo deleted the bug/fix_py2_deprecation branch October 17, 2019 08:32
@iranzo iranzo mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codificat codificat Awaiting requested review from codificat

@iranzo iranzo Awaiting requested review from iranzo

Assignees

@iranzo iranzo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jparrill @iranzo @kubevirt-bot