Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Broken Link and Typo #118

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Conversation

ansijain
Copy link
Contributor

@ansijain ansijain commented Apr 5, 2021

Signed-off-by: ansijain ansi.jain@india.nec.com

Signed-off-by: ansijain <ansi.jain@india.nec.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 5, 2021
@kubevirt-bot
Copy link

Hi @ansijain. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS labels Apr 5, 2021
Signed-off-by: ansijain <ansi.jain@india.nec.com>
@ansijain ansijain changed the title Fixed Broken Link Fixed Broken Link and Typo Apr 5, 2021
@mazzystr
Copy link
Contributor

mazzystr commented Apr 5, 2021

/approve
/lgtm

Thanks for the fixes!

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2021
@mazzystr
Copy link
Contributor

mazzystr commented Apr 5, 2021

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2021
Signed-off-by: ansijain <ansi.jain@india.nec.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@ansijain
Copy link
Contributor Author

ansijain commented Apr 8, 2021

Fixed one more link
@mazzystr can you please have a look

labs/lab000/lab000.md Outdated Show resolved Hide resolved
Signed-off-by: ansijain <ansi.jain@india.nec.com>
@mazzystr
Copy link
Contributor

mazzystr commented Apr 9, 2021

Thanks!

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2021
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ansijain ansijain requested a review from mazzystr April 9, 2021 17:36
@ansijain
Copy link
Contributor Author

/retest

@ansijain
Copy link
Contributor Author

@mazzystr Can you please have a look and let me know what should I do
as test is failing and giving error ERROR: This script does not work on Python 3.5 The minimum supported Python version is 3.6. Please use https://bootstrap.pypa.io/pip/3.5/get-pip.py instead.

@ansijain
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit b6e9a37 into kubevirt:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants