-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup partner compatibility testing framework #247
Merged
kubevirt-bot
merged 7 commits into
kubevirt:main
from
ShellyKa13:bash-script-for-testing
May 23, 2024
Merged
Add backup partner compatibility testing framework #247
kubevirt-bot
merged 7 commits into
kubevirt:main
from
ShellyKa13:bash-script-for-testing
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ignore should only ignore the velero vendor files which will always start with velero-v. Next commit I will add other files with `velero` in the path which I dont want to be ignored. Signed-off-by: Shelly Kagan <skagan@redhat.com>
This script will be used as the default script to run backup and restore command in PartnerComp labeled test. This will allow partners to write their own script and run those tests with their own backup-restore solution. Signed-off-by: Shelly Kagan <skagan@redhat.com>
Can define which script to build by: export BACKUP_SCRIPT_PATH=<path/to/script.go> run make build-backup-script The build will run automatically when running the functests Signed-off-by: Shelly Kagan <skagan@redhat.com>
prevent getting the following warning when running the tests: Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages: Ginkgo CLI Version: 2.4.0 Mismatched package versions found: 2.11.0 used by tests You're using deprecated Ginkgo functionality: ============================================= CurrentGinkgoTestDescription() is deprecated in Ginkgo V2. Use CurrentSpecReport() instead. Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
/retest |
The documentation explains how a backup partner can test its compatibility with the kubevirt project Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
25b260d
to
cfce077
Compare
8 tasks
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
dco-signoff: yes
Indicates the PR's author has DCO signed all their commits.
lgtm
Indicates that a PR is ready to be merged.
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Generalize tests marked with label PartnerComp to run with configured script used to backup and restore.
Added documentation for backup partner explaining what needs to be done in order to run the tests with their backup solution.
Added a script for Velero.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: