Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backup partner compatibility testing framework #247

Merged
merged 7 commits into from
May 23, 2024

Conversation

ShellyKa13
Copy link
Contributor

@ShellyKa13 ShellyKa13 commented May 2, 2024

What this PR does / why we need it:
Generalize tests marked with label PartnerComp to run with configured script used to backup and restore.
Added documentation for backup partner explaining what needs to be done in order to run the tests with their backup solution.
Added a script for Velero.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Backup partner compatibility testing framework

The ignore should only ignore the velero vendor files
which will always start with velero-v.
Next commit I will add other files with `velero`
in the path which I dont want to be ignored.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
This script will be used as the default script
to run backup and restore command in PartnerComp
labeled test. This will allow partners to write their own
script and run those tests with their own backup-restore solution.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
Can define which script to build by:
export BACKUP_SCRIPT_PATH=<path/to/script.go>
run make build-backup-script
The build will run automatically when running the functests

Signed-off-by: Shelly Kagan <skagan@redhat.com>
prevent getting the following warning when running the tests:
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.4.0
  Mismatched package versions found:
    2.11.0 used by tests

You're using deprecated Ginkgo functionality:
=============================================
  CurrentGinkgoTestDescription() is deprecated in Ginkgo V2.  Use CurrentSpecReport() instead.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 2, 2024
@ShellyKa13
Copy link
Contributor Author

/retest

The documentation explains how a backup partner can test its
compatibility with the kubevirt project

Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@kubevirt-bot kubevirt-bot merged commit b491c5b into kubevirt:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants