Skip to content

Commit

Permalink
add functional test for kubevirt_vmi_non_evictable metric
Browse files Browse the repository at this point in the history
Signed-off-by: Ezra Silvera <ezra@il.ibm.com>
  • Loading branch information
ezrasilvera committed Apr 5, 2021
1 parent 549ae6c commit 0623248
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/monitoring/vms/prometheus/prometheus_test.go
Expand Up @@ -1131,7 +1131,7 @@ func createVMISForEviction(evictable bool, migratable bool) []*k6tv1.VirtualMach
Name: "testvmi",
},
Status: k6tv1.VirtualMachineInstanceStatus{
Conditions: []v1.VirtualMachineInstanceCondition{
Conditions: []k6tv1.VirtualMachineInstanceCondition{
{
Type: k6tv1.VirtualMachineInstanceIsMigratable,
Status: status,
Expand Down
20 changes: 20 additions & 0 deletions tests/infra_test.go
Expand Up @@ -900,6 +900,26 @@ var _ = Describe("[Serial][owner:@sig-compute]Infrastructure", func() {
table.Entry("by IPv6", k8sv1.IPv6Protocol),
)

table.DescribeTable("should include VMI eviction blocker status for all running VMs", func(family k8sv1.IPFamily) {
if family == k8sv1.IPv6Protocol {
libnet.SkipWhenNotDualStackCluster(virtClient)
}

ip := getSupportedIP(metricsIPs, family)

metrics := collectMetrics(ip, "kubevirt_vmi_non_evictable")
By("Checking the collected metrics")
keys := getKeysFromMetrics(metrics)
for _, key := range keys {
value := metrics[key]
fmt.Fprintf(GinkgoWriter, "metric value was %f\n", value)
Expect(value).To(BeNumerically(">=", float64(0.0)))
}
},
table.Entry("[test_id:4148] by IPv4", k8sv1.IPv4Protocol),
table.Entry("by IPv6", k8sv1.IPv6Protocol),
)

table.DescribeTable("should include kubernetes labels to VMI metrics", func(family k8sv1.IPFamily) {
if family == k8sv1.IPv6Protocol {
libnet.SkipWhenNotDualStackCluster(virtClient)
Expand Down

0 comments on commit 0623248

Please sign in to comment.