Skip to content

Commit

Permalink
Apply monitoringlinter
Browse files Browse the repository at this point in the history
Apply monitoringlinter, which is designed to enforce
kubevirt/community#219 by ensuring that monitoring-related practices are
implemented within the pkg/monitoring directory using
operator-observability methods.

Signed-off-by: assafad <aadmi@redhat.com>
  • Loading branch information
assafad committed Mar 10, 2024
1 parent c722ca8 commit 4fd95c7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ lint:
./pkg/... \
./tests/... \
"
hack/dockerized "monitoringlinter ./pkg/..."

lint-metrics:
hack/dockerized "./hack/prom-metric-linter/metrics_collector.sh > metrics.json"
Expand Down
1 change: 1 addition & 0 deletions hack/builder/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ RUN set -x && \
go install -v k8s.io/code-generator/cmd/client-gen@v0.20.2 && \
go install -v github.com/securego/gosec/v2/cmd/gosec@0ce48a5 && \
go install -v sigs.k8s.io/controller-tools/cmd/controller-gen@v0.4.0 && \
go install -v github.com/kubevirt/monitoring/monitoringlinter/cmd/monitoringlinter@latest && \
go clean -cache -modcache

RUN set -x && \
Expand Down
2 changes: 1 addition & 1 deletion hack/dockerized
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ fi

fail_if_cri_bin_missing

KUBEVIRT_BUILDER_IMAGE=${KUBEVIRT_BUILDER_IMAGE:-"quay.io/kubevirt/builder:2403080945-556ae2ce2"}
KUBEVIRT_BUILDER_IMAGE=${KUBEVIRT_BUILDER_IMAGE:-"quay.io/kubevirt/builder:2403071413-652c5e632"}

SYNC_OUT=${SYNC_OUT:-true}

Expand Down

0 comments on commit 4fd95c7

Please sign in to comment.