Skip to content

Commit

Permalink
Fix test for backport
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Wels <awels@redhat.com>
  • Loading branch information
awels committed Mar 2, 2023
1 parent 2be809e commit 6d21840
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions tests/storage/hotplug.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ import (
"strconv"
"time"

"kubevirt.io/kubevirt/tests/util"

"kubevirt.io/client-go/log"

expect "github.com/google/goexpect"
Expand Down Expand Up @@ -1175,7 +1173,7 @@ var _ = SIGDescribe("Hotplug", func() {
createVMWithRatio := func(memRatio, cpuRatio float64) *v1.VirtualMachine {
vm := tests.NewRandomVMWithDataVolumeWithRegistryImport(
cd.DataVolumeImportUrlForContainerDisk(cd.ContainerDiskCirros),
testsuite.GetTestNamespace(nil), sc, corev1.ReadWriteOnce)
util.NamespaceTestDefault, sc, corev1.ReadWriteOnce)

memLimit := int64(1024 * 1024 * 128) //128Mi
memRequest := int64(math.Ceil(float64(memLimit) / memRatio))
Expand All @@ -1191,10 +1189,10 @@ var _ = SIGDescribe("Hotplug", func() {
vm.Spec.Template.Spec.Domain.Resources.Limits[corev1.ResourceMemory] = *memLimitQuantity
vm.Spec.Template.Spec.Domain.Resources.Limits[corev1.ResourceCPU] = *cpuLimitQuantity
vm.Spec.Running = pointer.BoolPtr(true)
vm, err := virtClient.VirtualMachine(testsuite.GetTestNamespace(vm)).Create(context.Background(), vm)
vm, err := virtClient.VirtualMachine(util.NamespaceTestDefault).Create(vm)
Expect(err).ToNot(HaveOccurred())
Eventually(func() bool {
vm, err = virtClient.VirtualMachine(testsuite.GetTestNamespace(vm)).Get(context.Background(), vm.Name, &metav1.GetOptions{})
vm, err = virtClient.VirtualMachine(util.NamespaceTestDefault).Get(vm.Name, &metav1.GetOptions{})
Expect(err).ToNot(HaveOccurred())
return vm.Status.Ready
}, 300*time.Second, 1*time.Second).Should(BeTrue())
Expand Down Expand Up @@ -1309,15 +1307,15 @@ var _ = SIGDescribe("Hotplug", func() {
vm := createVMWithRatio(memRatio, cpuRatio)
dv := createDataVolumeAndWaitForImport(sc, corev1.PersistentVolumeBlock)

vmi, err := virtClient.VirtualMachineInstance(vm.Namespace).Get(context.Background(), vm.Name, &metav1.GetOptions{})
vmi, err := virtClient.VirtualMachineInstance(vm.Namespace).Get(vm.Name, &metav1.GetOptions{})
Expect(err).ToNot(HaveOccurred())
libwait.WaitForSuccessfulVMIStartWithTimeout(vmi, 240)
tests.WaitForSuccessfulVMIStartWithTimeout(vmi, 240)

By(addingVolumeRunningVM)
addDVVolumeVM(vm.Name, vm.Namespace, "testvolume", dv.Name, v1.DiskBusSCSI, false, "")
By(verifyingVolumeDiskInVM)
verifyVolumeAndDiskVMAdded(virtClient, vm, "testvolume")
vmi, err = virtClient.VirtualMachineInstance(vm.Namespace).Get(context.Background(), vm.Name, &metav1.GetOptions{})
vmi, err = virtClient.VirtualMachineInstance(vm.Namespace).Get(vm.Name, &metav1.GetOptions{})
Expect(err).ToNot(HaveOccurred())
verifyVolumeAndDiskVMIAdded(virtClient, vmi, "testvolume")
verifyVolumeStatus(vmi, v1.VolumeReady, "", "testvolume")
Expand Down Expand Up @@ -1354,7 +1352,7 @@ var _ = SIGDescribe("Hotplug", func() {

By("Remove volume from a running VM")
removeVolumeVM(vm.Name, vm.Namespace, "testvolume", false)
_, err = virtClient.VirtualMachineInstance(vm.Namespace).Get(context.Background(), vm.Name, &metav1.GetOptions{})
_, err = virtClient.VirtualMachineInstance(vm.Namespace).Get(vm.Name, &metav1.GetOptions{})
Expect(err).ToNot(HaveOccurred())
},
Entry("[Serial]1 to 1 cpu and mem ratio", Serial, float64(1), float64(1)),
Expand Down

0 comments on commit 6d21840

Please sign in to comment.